From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: bug in save-some-buffers or diff.el? Date: 22 Oct 2003 17:35:14 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87ismh49y5.fsf@mail.jurta.org> References: <874qy1brau.fsf@mail.jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1066833600 1020 80.91.224.253 (22 Oct 2003 14:40:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Oct 2003 14:40:00 +0000 (UTC) Cc: David Abrahams Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Oct 22 16:39:58 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACK9W-0004IC-00 for ; Wed, 22 Oct 2003 16:39:58 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ACK9V-00066T-00 for ; Wed, 22 Oct 2003 16:39:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ACK9Q-0007Rv-Ew for emacs-devel@quimby.gnus.org; Wed, 22 Oct 2003 10:39:52 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ACK8z-0007Gz-T4 for emacs-devel@gnu.org; Wed, 22 Oct 2003 10:39:25 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ACK8R-000707-Kh for emacs-devel@gnu.org; Wed, 22 Oct 2003 10:39:22 -0400 Original-Received: from [64.246.52.232] (helo=ns5.tangramltd.com) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.24) id 1ACK8P-0006yO-W3 for emacs-devel@gnu.org; Wed, 22 Oct 2003 10:38:50 -0400 Original-Received: from 80-235-32-176-dsl.mus.estpak.ee ([80.235.32.176] helo=mail.jurta.org) by ns5.tangramltd.com with esmtp (Exim 4.20) id 1ACK8I-0000rN-9U; Wed, 22 Oct 2003 17:38:43 +0300 Original-To: emacs-devel@gnu.org In-Reply-To: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 48 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ns5.tangramltd.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - jurta.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17340 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17340 David Abrahams writes: > Juri Linkov writes: > > David Abrahams writes: > >> Here's my backtrace: > >> Debugger entered--Lisp error: (wrong-type-argument stringp nil) > >> expand-file-name(nil) > >> find-file-noselect(nil) > >> diff-parse-differences(732 nil) > > > > This bug is already fixed and yesterday checked in to CVS (files > > compile.el and diff.el). This bug was caused by setting the variable > > `compile-auto-highlight' to t. Now it is nil by default. > > However, even if you set it back to t, it will not cause the same bug, > > because function `diff-parse-differences' now is changed not to > > call the `find-file-noselect' at all. > > Well, the problem was repro'd in a version of emacs built yesterday > at approx. 5pm EST, and neither of those two files has changed since > I did my checkout. I appear to have both changes, as well. > > Hmm, maybe I need to do > > nmake recompile && nmake install > > in the lisp directory? It surprises me that > > nmake && nmake install > > from the nt directory is insufficient after updating my local CVS > image. Your backtrace indicates that you use older version of diff.el, because newest version have no `find-file-noselect' function call at all. I can't tell how to recompile .el files under Windows, but it's clear that your .elc files are older than fixed .el files. BTW, I'm sure that current behavior of `load' is wrong. It always tries to load .elc file first, even if it's older than .el. But often it causes too much trouble after updating .el files. There are many reasons why this happens: user forgets to recompile updated .el files, something goes wrong in the make process, etc. Yes, `load' reports a warning, but usually this warning goes unnoticed, which results in broken functionality. Instead, `load' should load the newest of .el or .elc files, and report the same warning as a simple reminder to recompile updated .el files to execute them faster. -- http://www.jurta.org/emacs/