unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Suggestion: small improvment for compilation
Date: Sat, 06 Aug 2005 21:12:16 +0300	[thread overview]
Message-ID: <87iryjkkpj.fsf@jurta.org> (raw)
In-Reply-To: <200508061403.j76E3xfH018690@beta.mvs.co.il> (Ehud Karni's message of "Sat, 6 Aug 2005 17:03:59 +0300")

> Below is small patch to compile.el. This patch add the line:
>     Compilation started at Mon Aug 01 17:09:03
> and highlight it in the same way as "Compilation finished".
>
> I add this because I have some very long compilations (e.g. build
> Emacs on Cygwin) and this helps me keep track of it.

Good idea.

I think it's better to use exactly the same format as used in the
function `compilation-handle-exit', i.e. `mode-name' instead of
`(capitalize name-of-mode)', and `(substring (current-time-string) 0 19)'
instead of `format-time-string'.

Also I see there is a difference in highlighting grep and compilation
exit messages.  In the grep output the mode name `Grep' is
not highlighted, but the exit code is highlighted (highlighting
is underlined below).

Grep exited abnormally with code 2 at Tue Jul 19 15:42:32
     =================           =

In the compilation output the mode name is highlighted,
but the exit code is not:

Compilation exited abnormally with code 1 at Wed Jul 20 12:21:12
=============================

Shouldn't they be more uniform?

-- 
Juri Linkov
http://www.jurta.org/emacs/

  reply	other threads:[~2005-08-06 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-06 14:03 Suggestion: small improvment for compilation Ehud Karni
2005-08-06 18:12 ` Juri Linkov [this message]
2005-08-13 19:10   ` Ehud Karni
2005-08-14  8:17     ` Juri Linkov
  -- strict thread matches above, loose matches on Subject: below --
2005-08-06 12:32 Ehud Karni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iryjkkpj.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).