From: "Arne Jørgensen" <arne@arnested.dk>
Subject: Re: latexenc and `TeX-master'
Date: Tue, 24 Jan 2006 00:04:37 +0100 [thread overview]
Message-ID: <87irsasfzu.fsf@arnested.dk> (raw)
In-Reply-To: 7F98F161-442F-40A7-9F67-563168439D3B@gmail.com
David Reitter <david.reitter@gmail.com> writes:
> On 22 Jan 2006, at 17:21, Arne Jørgensen wrote:
>
>> Arne Jørgensen <arne@arnested.dk> writes:
>>
>>> But it is probably better to check if the file is a regular and then
>>> also check if it is actually readable.
>>
>> Readability is already checked later in the code. Checking whether the
>> file is a regular file is also better checked at that point.
>
> yes, I agree. The second change (below) should catch all other cases.
>
>
> *** latexenc.el 02 Dec 2005 13:24:11 +0000 1.11
> --- latexenc.el 22 Jan 2006 08:52:12 +0000
> ***************
> *** 174,180 ****
> (find-file-noselect latexenc-main-file t)))
> (coding-system-base ;Disregard the EOL part of
> the CS.
> (with-current-buffer latexenc-main-buffer
> ! (or coding-system-for-write buffer-file-coding-
> system))))
> 'undecided))))
> 'undecided))
>
> --- 175,183 ----
> (find-file-noselect latexenc-main-file t)))
> (coding-system-base ;Disregard the EOL part of
> the CS.
> (with-current-buffer latexenc-main-buffer
> ! (or coding-system-for-write
> ! buffer-file-coding-system
> ! 'undecided))))
> 'undecided))))
> 'undecided))
On a first read I just thought this fix was a reindentation of the
code, but now that I've read it more carefully I think it should be
applied :-)
Kind regards
/arne
--
Arne Jørgensen <http://arnested.dk/>
next prev parent reply other threads:[~2006-01-23 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 8:58 latexenc and `TeX-master' David Reitter
2006-01-22 14:24 ` Arne Jørgensen
2006-01-22 17:21 ` Arne Jørgensen
2006-01-23 9:54 ` David Reitter
2006-01-23 23:04 ` Arne Jørgensen [this message]
2006-01-23 14:31 ` Reiner Steib
2006-01-23 14:53 ` Arne Jørgensen
2006-01-22 14:26 ` Arne Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87irsasfzu.fsf@arnested.dk \
--to=arne@arnested.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).