From: michael.cadilhac@lrde.org (Michaël Cadilhac)
Subject: Re: [Proposal] M-x tabify to indent only when needed.
Date: Mon, 24 Jul 2006 22:40:15 +0200 [thread overview]
Message-ID: <87irlm68k0.fsf@lrde.org> (raw)
In-Reply-To: <8764hm7vwo.fsf@lrde.org> (Michaël Cadilhac's message of "Mon, 24 Jul 2006 19:30:31 +0200")
[-- Attachment #1.1.1: Type: text/plain, Size: 549 bytes --]
michael.cadilhac@lrde.org (Michaël Cadilhac) writes:
> M-x tabify has an unexpected behavior with files that are already
> tabified: once it is called, the file is set to be modified. In fact,
> the regions of spaces are removed and then re-added.
>
> Can the following patch be applied to change this behavior?
>
> It checks that the region we are going to delete is not already of the
> form « tabs then spaces less than a tab. ».
... Sorry for the noise, the previous patch was no good. Please
consider the following one.
[-- Attachment #1.1.2: tabify.patch --]
[-- Type: text/x-patch, Size: 1240 bytes --]
*** lisp/tabify.el.~1.19.~ 2006-02-06 15:33:35.000000000 +0100
--- lisp/tabify.el 2006-07-24 22:33:57.000000000 +0200
***************
*** 75,82 ****
(while (re-search-forward tabify-regexp nil t)
(let ((column (current-column))
(indent-tabs-mode t))
! (delete-region (match-beginning 0) (point))
! (indent-to column))))))
(provide 'tabify)
--- 75,90 ----
(while (re-search-forward tabify-regexp nil t)
(let ((column (current-column))
(indent-tabs-mode t))
! ;; Whether already tabified.
! (unless (save-match-data
! (save-excursion
! (skip-chars-backward " ")
! (string-match
! (format "^\t* \\{0,%d\\}$"
! (- tab-width (1+ (mod (current-column) tab-width))))
! (match-string 0))))
! (delete-region (match-beginning 0) (point))
! (indent-to column)))))))
(provide 'tabify)
*** lisp/ChangeLog.~1.9820.~ 2006-07-17 13:27:46.000000000 +0200
--- lisp/ChangeLog 2006-07-24 19:20:58.000000000 +0200
***************
*** 1,0 ****
--- 1,4 ----
+ 2006-07-24 Michaël Cadilhac <michael.cadilhac@lrde.org>
+
+ * tabify.el (tabify): Check if not already tabified before indenting.
+
[-- Attachment #1.1.3: Type: text/plain, Size: 331 bytes --]
TIA!
--
| Michaël `Micha' Cadilhac | Pour les 35-40 ans, l'humour |
| Epita/LRDE Promo 2007 | c'est une plus-value. |
| http://www.lrde.org/~cadilh_m | -- Guillaume L. |
`-- - JID: micha@amessage.be --' - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-07-24 20:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 17:30 [Proposal] M-x tabify to indent only when needed Michaël Cadilhac
2006-07-24 20:40 ` Michaël Cadilhac [this message]
2006-07-24 21:30 ` Stefan Monnier
2006-07-25 3:09 ` Richard Stallman
2006-07-25 13:55 ` Stefan Monnier
2006-07-25 14:09 ` Michaël Cadilhac
2006-07-25 15:07 ` Stefan Monnier
2006-07-25 15:28 ` Michaël Cadilhac
2006-07-25 16:21 ` Stefan Monnier
2006-07-25 17:09 ` Michaël Cadilhac
2006-07-24 21:50 ` Richard Stallman
2006-07-25 11:38 ` Michaël Cadilhac
2006-07-25 22:15 ` Richard Stallman
2006-07-26 11:29 ` Michaël Cadilhac
2006-07-26 11:32 ` Michaël Cadilhac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87irlm68k0.fsf@lrde.org \
--to=michael.cadilhac@lrde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).