dns-mode.el vs. zone-mode.el

dns-mode.el vs. zone-mode.el

[Romain Francoise]

Emacs 22 has a new package called dns-mode.el which does pretty much the
same thing as an older package called zone-mode.el, the latter being
part of Emacs since (at least) Emacs 20.

They are so simple that we probably don't need two packages for this.

Comparing the two yields the following observations:
- dns-mode's code to update serials is more advanced and probably more
  robust;
- dns-mode's font-locking is much better;
- zone-mode updates serials automatically upon saving, via
  `write-file-functions';
- dns-mode has a menu (but it has only one item so far);
- dns-mode associates itself with .soa files in `auto-mode-alist'.

So I'm proposing to merge the two by dropping zone-mode.el, making
zone-mode an alias for dns-mode, and making dns-mode update serials
automatically upon saving (so as not to confuse users of zone-mode).

What do people think?

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: dns-mode.el vs. zone-mode.el

[Simon Josefsson]

Romain Francoise <romain@orebokech.com> writes:

> Emacs 22 has a new package called dns-mode.el which does pretty much the
> same thing as an older package called zone-mode.el, the latter being
> part of Emacs since (at least) Emacs 20.
>
> They are so simple that we probably don't need two packages for this.
>
> Comparing the two yields the following observations:
> - dns-mode's code to update serials is more advanced and probably more
>   robust;
> - dns-mode's font-locking is much better;
> - zone-mode updates serials automatically upon saving, via
>   `write-file-functions';
> - dns-mode has a menu (but it has only one item so far);
> - dns-mode associates itself with .soa files in `auto-mode-alist'.
>
> So I'm proposing to merge the two by dropping zone-mode.el, making
> zone-mode an alias for dns-mode, and making dns-mode update serials
> automatically upon saving (so as not to confuse users of zone-mode).
>
> What do people think?

Sounds good to me.  (Actually, I was not aware of zone-mode.el when I
wrote dns-mode.)

Re: dns-mode.el vs. zone-mode.el

[Bill Wohler]

Romain Francoise <romain@orebokech.com> writes:

> So I'm proposing to merge the two by dropping zone-mode.el, making
> zone-mode an alias for dns-mode, and making dns-mode update serials
> automatically upon saving (so as not to confuse users of zone-mode).
>
> What do people think?

Agreed. dns-mode also has a better name. Yes, please incorporate the
serial update of zone-mode. It uses the same format I use (and most
people, I suppose), so that's good. Thanks.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD

Re: dns-mode.el vs. zone-mode.el

[Richard Stallman]

    So I'm proposing to merge the two by dropping zone-mode.el, making
    zone-mode an alias for dns-mode, and making dns-mode update serials
    automatically upon saving (so as not to confuse users of zone-mode).

    What do people think?

Please do it.

Re: dns-mode.el vs. zone-mode.el

[Romain Francoise]

Richard Stallman <rms@gnu.org> writes:

> Please do it.

Done.

While I was at it I added a defcustom to control the automatic
incrementing of the serial, zone-mode didn't have one.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: dns-mode.el vs. zone-mode.el

[Romain Francoise]

Bill Wohler <wohler@newt.com> writes:

> Yes, please incorporate the serial update of zone-mode. It uses the
> same format I use (and most people, I suppose), so that's good.

What I took from zone-mode is the fact that serials are incremented upon
saving, the updating code in dns-mode was already there and is much more
advanced than that of zone-mode (it supports a variety of formats).

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: dns-mode.el vs. zone-mode.el

[Edward O'Connor]

Romain Francoise wrote:

> What I took from zone-mode is the fact that serials are incremented
> upon saving, the updating code in dns-mode was already there and is
> much more advanced than that of zone-mode (it supports a variety of
> formats).

FWIW, I've had this in ~/.emacs for some time:

  (add-hook 'dns-mode-hook
            (lambda ()
              (add-hook 'before-save-hook
                        'dns-mode-soa-increment-serial
                        nil t)))

Will the recent dns-mode changes cause me to increment the serial twice
on each save?


Ted

-- 
Edward O'Connor
hober0@gmail.com

Ense petit placidam sub libertate quietem.

Re: dns-mode.el vs. zone-mode.el

[Romain Francoise]

Edward O'Connor <hober0@gmail.com> writes:

> FWIW, I've had this in ~/.emacs for some time:

>   (add-hook 'dns-mode-hook
>             (lambda ()
>               (add-hook 'before-save-hook
>                         'dns-mode-soa-increment-serial
>                         nil t)))

> Will the recent dns-mode changes cause me to increment the serial twice
> on each save?

Yes, but you can either remove that from your ~/.emacs, or if it's not
desirable for whatever reason, set `dns-mode-soa-auto-increment-serial'
to nil.

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: dns-mode.el vs. zone-mode.el

[Bill Wohler]

Romain Francoise <romain@orebokech.com> writes:

> Edward O'Connor <hober0@gmail.com> writes:
>
>> FWIW, I've had this in ~/.emacs for some time:
>
>>   (add-hook 'dns-mode-hook
>>             (lambda ()
>>               (add-hook 'before-save-hook
>>                         'dns-mode-soa-increment-serial
>>                         nil t)))
>
>> Will the recent dns-mode changes cause me to increment the serial twice
>> on each save?
>
> Yes, but you can either remove that from your ~/.emacs, or if it's not
> desirable for whatever reason, set `dns-mode-soa-auto-increment-serial'
> to nil.

This note should definitely be added to NEWS so that users of dns-mode
can proactively clean up their .emacs upon the upgrade to Emacs 22.

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD

Re: dns-mode.el vs. zone-mode.el

[Romain Francoise]

Bill Wohler <wohler@newt.com> writes:

> This note should definitely be added to NEWS so that users of dns-mode
> can proactively clean up their .emacs upon the upgrade to Emacs 22.

NEWS is way too long already (6000 lines for Emacs 22.1 only), and
people who have this kind of customizations in their init files are
probably smart enough to realize what's happening if Emacs 22 increments
their serials twice...

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: dns-mode.el vs. zone-mode.el

[Bill Wohler]

Romain Francoise <romain@orebokech.com> writes:

> Bill Wohler <wohler@newt.com> writes:
>
>> This note should definitely be added to NEWS so that users of dns-mode
>> can proactively clean up their .emacs upon the upgrade to Emacs 22.
>
> NEWS is way too long already (6000 lines for Emacs 22.1 only), and
> people who have this kind of customizations in their init files are
> probably smart enough to realize what's happening if Emacs 22 increments
> their serials twice...

That's not a good reason not to mention it. A better reason is that
dns-mode didn't exist in Emacs 21 ;-).

-- 
Bill Wohler <wohler@newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD

Re: dns-mode.el vs. zone-mode.el

[David Kastrup]

Bill Wohler <wohler@newt.com> writes:

> Romain Francoise <romain@orebokech.com> writes:
>
>> Bill Wohler <wohler@newt.com> writes:
>>
>>> This note should definitely be added to NEWS so that users of dns-mode
>>> can proactively clean up their .emacs upon the upgrade to Emacs 22.
>>
>> NEWS is way too long already (6000 lines for Emacs 22.1 only), and
>> people who have this kind of customizations in their init files are
>> probably smart enough to realize what's happening if Emacs 22 increments
>> their serials twice...
>
> That's not a good reason not to mention it. A better reason is that
> dns-mode didn't exist in Emacs 21 ;-).

Definitely.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum