From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Diane Murray Newsgroups: gmane.emacs.devel Subject: [Patch] url-cookie-write-file saves versioned backups Date: Mon, 28 Aug 2006 01:53:45 +0200 Message-ID: <87irkdrb06.fsf@x3y2z1.net> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1156722796 18533 80.91.229.2 (27 Aug 2006 23:53:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2006 23:53:16 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 28 01:53:13 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GHURE-0003Mx-RJ for ged-emacs-devel@m.gmane.org; Mon, 28 Aug 2006 01:53:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GHURE-0004oJ-Be for ged-emacs-devel@m.gmane.org; Sun, 27 Aug 2006 19:53:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GHUR1-0004nk-Ad for emacs-devel@gnu.org; Sun, 27 Aug 2006 19:52:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GHUQy-0004mD-J1 for emacs-devel@gnu.org; Sun, 27 Aug 2006 19:52:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GHUQy-0004m1-Ek for emacs-devel@gnu.org; Sun, 27 Aug 2006 19:52:56 -0400 Original-Received: from [194.25.134.17] (helo=mailout02.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GHUZn-0005Bc-QR for emacs-devel@gnu.org; Sun, 27 Aug 2006 20:02:04 -0400 Original-Received: from fwd33.aul.t-online.de by mailout02.sul.t-online.com with smtp id 1GHUQw-0001U8-02; Mon, 28 Aug 2006 01:52:54 +0200 Original-Received: from spargel (Z2acD8ZcQe69dkCkscOHHYT2BcppSHC2L4YMWg+UvuZz9jnlA6o6sK@[84.189.228.103]) by fwd33.sul.t-online.de with esmtp id 1GHUQo-1Z6BjE0; Mon, 28 Aug 2006 01:52:46 +0200 Original-To: emacs-devel@gnu.org X-ID: Z2acD8ZcQe69dkCkscOHHYT2BcppSHC2L4YMWg+UvuZz9jnlA6o6sK@t-dialin.net X-TOI-MSGID: 254eb126-c066-40cb-a480-b9a613fdbe62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58966 Archived-At: Versioned backups of the cookies file are being saved (contrary to the intent of the last changes made to url-cookie.el in revision 1.18), which causes `backup-buffer' to ask for confirmation to delete those excess backup files. Additionally, the error "Local variables list is not properly terminated" occurs when opening the cookies file. The following patch corrects this. I submitted earlier patches using the email , if for some reason that needs to be known. * url-cookie.el (url-cookie-write-file): Insert a newline character before the Local Variables line. Set `version-control' to never. *** url-cookie.el 13 Jul 2006 03:53:15 +0200 1.18 --- url-cookie.el 27 Aug 2006 15:25:21 +0200 *************** *** 168,178 **** (insert ")\n(setq url-cookie-secure-storage\n '") (pp url-cookie-secure-storage (current-buffer)) (insert ")\n") ! (insert " ;; Local Variables:\n" ";; version-control: never\n" ";; no-byte-compile: t\n" ";; End:\n") ! (set (make-local-variable 'version-control) t) (write-file fname) (setq url-cookies-changed-since-last-save nil) (kill-buffer (current-buffer)))))) --- 168,178 ---- (insert ")\n(setq url-cookie-secure-storage\n '") (pp url-cookie-secure-storage (current-buffer)) (insert ")\n") ! (insert " \n;; Local Variables:\n" ";; version-control: never\n" ";; no-byte-compile: t\n" ";; End:\n") ! (set (make-local-variable 'version-control) 'never) (write-file fname) (setq url-cookies-changed-since-last-save nil) (kill-buffer (current-buffer))))))