From: michael@cadilhac.name (Michaël Cadilhac)
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: hannes@saeurebad.de, emacs-devel@gnu.org
Subject: Re: Your last change to browse-url is bogus.
Date: Mon, 17 Sep 2007 13:52:32 +0200 [thread overview]
Message-ID: <87ir69cxvj.fsf@cadilhac.name> (raw)
In-Reply-To: <wl4phtc3am.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Mon, 17 Sep 2007 13:40:49 +0900")
[-- Attachment #1.1: Type: text/plain, Size: 1377 bytes --]
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> Your point of view is low-level (string operation), and mine is
> high-level (URL operation). The problems is that the current
> implementation of browse-url-encode-url is neither of them: it looks
> like a result of superficial code factoring.
I do agree.
> I propose the combination of above two, which is similar to what Davis
> suggested:
>
> 1. Add a low-level string replacing function (say,
> browse-url-encode-chars-in-string as you mentioned) that takes an
> argument representing the characters to be escaped.
>
> 2. In browse-url-file-url, directly call the above low-level
> function instead of calling browse-url-encode-url.
>
> 3. Change browse-url-encode-url so it calls the the low-level
> function introduced in 1, and just do one task (URL -> URL).
Yeah, I did that on the weekend. If nobody complains, it seems that we
agree that this is TRT, so I'll install the change later on.
Thank you all for this debate.
--
| Michaël `Micha' Cadilhac | Je veut dire que la loi francaise |
| http://michael.cadilhac.name | est overwritable par le |
| JID/MSN: | reglement interieur il me semble. |
`---- michael.cadilhac@gmail.com | -- ElBarto - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-09-17 11:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 9:13 Your last change to browse-url is bogus Michaël Cadilhac
2007-09-12 10:20 ` Johannes Weiner
2007-09-12 10:38 ` Michaël Cadilhac
2007-09-12 10:49 ` Johannes Weiner
2007-09-12 11:09 ` Michaël Cadilhac
2007-09-12 11:25 ` Johannes Weiner
2007-09-12 11:46 ` Michaël Cadilhac
2007-09-12 12:54 ` YAMAMOTO Mitsuharu
2007-09-12 13:13 ` Michaël Cadilhac
2007-09-12 14:18 ` YAMAMOTO Mitsuharu
2007-09-12 22:50 ` Michaël Cadilhac
2007-09-17 4:40 ` YAMAMOTO Mitsuharu
2007-09-17 11:52 ` Michaël Cadilhac [this message]
2007-09-12 23:29 ` Stephen J. Turnbull
2007-09-13 2:30 ` Stefan Monnier
2007-09-13 18:15 ` Stephen J. Turnbull
2007-09-13 21:44 ` Stefan Monnier
2007-09-13 2:39 ` Davis Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ir69cxvj.fsf@cadilhac.name \
--to=michael@cadilhac.name \
--cc=emacs-devel@gnu.org \
--cc=hannes@saeurebad.de \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).