unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* recent changes to display code
@ 2007-11-06  2:42 Glenn Morris
  2007-11-06  4:45 ` Chong Yidong
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2007-11-06  2:42 UTC (permalink / raw)
  To: Richard Stallman; +Cc: emacs-devel


Something in your 2007-11-04 change to the src/ directory of the
EMACS_22_BASE branch has fairly badly messed up Emacs for me. The
ChangeLog entry is also missing.

./src/emacs -Q
  -> mode-line and scroll-bar are "missing" (in the sense of being
  empty and just looking like the normal buffer background).

The scroll bar appears if I type something into scratch.

This is on GNU/Linux, configured with:

--with-x-toolkit=athena --without-toolkit-scroll-bars

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: recent changes to display code
  2007-11-06  2:42 recent changes to display code Glenn Morris
@ 2007-11-06  4:45 ` Chong Yidong
  2007-11-07  0:15   ` Richard Stallman
  0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2007-11-06  4:45 UTC (permalink / raw)
  To: Glenn Morris; +Cc: Richard Stallman, emacs-devel

Glenn Morris <rgm@gnu.org> writes:

> Something in your 2007-11-04 change to the src/ directory of the
> EMACS_22_BASE branch has fairly badly messed up Emacs for me. The
> ChangeLog entry is also missing.
>
> ./src/emacs -Q
>   -> mode-line and scroll-bar are "missing" (in the sense of being
>   empty and just looking like the normal buffer background).
>
> The scroll bar appears if I type something into scratch.

I see the problem too.  What bug is this redisplay change supposed to
fix, and why is it in EMACS_22_BASE as opposed to the trunk?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: recent changes to display code
  2007-11-06  4:45 ` Chong Yidong
@ 2007-11-07  0:15   ` Richard Stallman
  2007-11-07 15:35     ` Chong Yidong
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2007-11-07  0:15 UTC (permalink / raw)
  To: Chong Yidong; +Cc: rgm, emacs-devel

    I see the problem too.  What bug is this redisplay change supposed to
    fix, and why is it in EMACS_22_BASE as opposed to the trunk?

It is meant to fix the problem that Joe Wells reported with overlay
properties.  I put it in Emacs 22 because these bugs were reported for
Emacs 22.  But I agree we should move it into the trunk.  Would
you please do that?

I'm surprised that this change affected any behavior.  It was only
supposed to make the argument OVERLAY available to
face_for_overlay_string.  I will take another look to see what might
have caused such a problem.

I wonder if there is some hidden constraint on the order of fields in
`struct it'.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: recent changes to display code
  2007-11-07  0:15   ` Richard Stallman
@ 2007-11-07 15:35     ` Chong Yidong
  0 siblings, 0 replies; 4+ messages in thread
From: Chong Yidong @ 2007-11-07 15:35 UTC (permalink / raw)
  To: rms; +Cc: rgm, emacs-devel

Richard Stallman <rms@gnu.org> writes:

> I'm surprised that this change affected any behavior.  It was only
> supposed to make the argument OVERLAY available to
> face_for_overlay_string.  I will take another look to see what might
> have caused such a problem.
>
> I wonder if there is some hidden constraint on the order of fields in
> `struct it'.

No, the bug arises because of a rather strange (presumable) typo in
your definition of from_overlay in handle_face_prop:

      Lisp_Object from_overlay
      = (it->current.overlay_string_index >= 0
         ? it->string_overlays[it->current.overlay_string_index]
            : from_overlay);
             ^^^^^^^^^^^^

I've fixed this in EMACS_22_BASE.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-07 15:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-06  2:42 recent changes to display code Glenn Morris
2007-11-06  4:45 ` Chong Yidong
2007-11-07  0:15   ` Richard Stallman
2007-11-07 15:35     ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).