unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH]: xmltok.el: (xmltok-forward): Minimal simplification
@ 2008-09-30  7:38 Mario Lang
  2008-10-03  7:41 ` Glenn Morris
  0 siblings, 1 reply; 2+ messages in thread
From: Mario Lang @ 2008-09-30  7:38 UTC (permalink / raw)
  To: emacs-devel

Hi.

While looking for some speedups in Emacs XML pasers for a project
of mine I noticed the following trivial changes that should probably
be done to `xmltok-forward'.  This is a trivial change, doesn't change
functionality.

--- a/lisp/nxml/xmltok.el
+++ b/lisp/nxml/xmltok.el
@@ -315,16 +315,14 @@ and VALUE-END, otherwise a STRING giving the value."
 	   (cond ((> space-count 0)
 		  (setq xmltok-type 'space))
 		 (t
-		  (goto-char (1+ (point)))
+		  (forward-char 1)
 		  (xmltok-scan-after-lt))))
 	  ((eq ch ?\&)
 	   (cond ((> space-count 0)
 		  (setq xmltok-type 'space))
 		 (t
-		  (goto-char (1+ (point)))
-		  (xmltok-scan-after-amp
-		   (lambda (start end)
-		     (xmltok-handle-entity start end))))))
+		  (forward-char 1)
+		  (xmltok-scan-after-amp 'xmltok-handle-entity))))
 	  ((re-search-forward "[<&]\\|\\(]]>\\)" nil t)
 	   (cond ((not (match-beginning 1))
 		  (goto-char (match-beginning 0))

-- 
CYa,
  ⡍⠁⠗⠊⠕ | Debian Developer <URL:http://debian.org/>
  .''`. | Get my public key via finger mlang/key@db.debian.org
 : :' : | 1024D/7FC1A0854909BCCDBE6C102DDFFC022A6B113E44
 `. `'
   `-      <URL:http://delysid.org/>  <URL:http://www.staff.tugraz.at/mlang/>




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]: xmltok.el: (xmltok-forward): Minimal simplification
  2008-09-30  7:38 [PATCH]: xmltok.el: (xmltok-forward): Minimal simplification Mario Lang
@ 2008-10-03  7:41 ` Glenn Morris
  0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2008-10-03  7:41 UTC (permalink / raw)
  To: Mario Lang; +Cc: emacs-devel

OK; installed.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-03  7:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-30  7:38 [PATCH]: xmltok.el: (xmltok-forward): Minimal simplification Mario Lang
2008-10-03  7:41 ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).