From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog Date: Wed, 10 Dec 2008 11:35:26 -0500 Message-ID: <87iqpsrnsh.fsf@cyd.mit.edu> References: <200812101546.mBAFkTpt025689@mothra.ics.uci.edu> <87vdts9fca.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1228926977 2825 80.91.229.12 (10 Dec 2008 16:36:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2008 16:36:17 +0000 (UTC) Cc: Dan Nicolaescu , Emacs Devel To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 17:37:21 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LAS3a-0000WH-6c for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 17:37:02 +0100 Original-Received: from localhost ([127.0.0.1]:43014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAS2O-00041T-W6 for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2008 11:35:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAS1z-0003t0-Ng for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:35:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAS1x-0003sB-Rq for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:35:23 -0500 Original-Received: from [199.232.76.173] (port=58510 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAS1x-0003s1-KR for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:35:21 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:55454) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LAS1x-0004jH-8x for emacs-devel@gnu.org; Wed, 10 Dec 2008 11:35:21 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 6E0C057E1C8; Wed, 10 Dec 2008 11:35:26 -0500 (EST) In-Reply-To: (Juanma Barranquero's message of "Wed, 10 Dec 2008 17:20:28 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106759 Archived-At: "Juanma Barranquero" writes: > But the base discussion is whether features should be tested by > feature tests, or lumped together into the WINDOWSNT, DOS_NT, > NS_IMPL_* bags. We've been saying for years that Emacs lisp programs > must not check the Emacs version, but features. The same reasoning > applies to checking HAVE_DAEMON vs. WINDOWSNT. That's typically true, but again: specifics matter. For instance, if the majority of the code controlled by the HAVE_DAEMON macro is platform-dependent anyway, we would simply be replacing #ifdef WINDOWSNT ... #endif with #ifdef HAVE_DAEMON #ifdef WINDOWSNT ... #endif ... #endif Which situation pertains in the actual code?