Re: Upcoming 23.1 release

[Yavor Doganov <yavor@gnu.org>]

YAMAMOTO Mitsuharu wrote:
> > Does GNUstep provide a meaningful implementation of
> > -[NSFontDescriptor matchingFontDescriptorsWithMandatoryKeys:]?
> > According to *1, it seems to be just a stub and always return nil.
> 
> Correction: not nil but an empty array.

Yes, you are right.  I filed a bug in the GNUstep tracker just in
case.  I hope it's fixed soon...

> Anyway it's not a meaningful result.

Definitely.  By "at least" I meant that you can at least build
Emacs.app and run it with -nw, which is practially the only way to use
it anyway.

Perhaps it's worth adding a comment in the code like the one below?


--- nsfont.m	24 юли 2009 16:02:17 +0300	1.26.2.3
+++ nsfont.m	24 юли 2009 18:05:49 +0300	
@@ -473,6 +473,10 @@
     if (isMatch)
 	[fkeys removeObject: NSFontFamilyAttribute];
 
+    /* As of 2009-07-24, GNUstep's implementation of
+       -[NSFontDescriptor matchingFontDescriptorsWithMandatoryKeys:]
+       is incomplete and the method always returns an empty array.
+       GNUstep bug: https://savannah.gnu.org/bugs/index.php?27099  */
     matchingDescs = [fdesc matchingFontDescriptorsWithMandatoryKeys: fkeys];
     if (NSFONT_TRACE)
 	NSLog(@"Got desc %@ and found %d matching fonts from it: ", fdesc,