From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts. Date: Thu, 08 Apr 2010 20:08:41 +0200 Message-ID: <87iq81izpy.fsf@telefonica.net> References: <87tyrlj0zo.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1270750210 10467 80.91.229.12 (8 Apr 2010 18:10:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Apr 2010 18:10:10 +0000 (UTC) Cc: "Jan D." To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 08 20:10:08 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NzwB4-0003D3-9u for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 20:10:07 +0200 Original-Received: from localhost ([127.0.0.1]:56586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzwAf-0007uV-GO for ged-emacs-devel@m.gmane.org; Thu, 08 Apr 2010 14:09:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzwA5-0007bJ-2I for emacs-devel@gnu.org; Thu, 08 Apr 2010 14:09:05 -0400 Original-Received: from [140.186.70.92] (port=57903 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzwA1-0007Yu-9l for emacs-devel@gnu.org; Thu, 08 Apr 2010 14:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nzw9z-0005nX-DX for emacs-devel@gnu.org; Thu, 08 Apr 2010 14:09:01 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:53811) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nzw9z-0005n6-7q for emacs-devel@gnu.org; Thu, 08 Apr 2010 14:08:59 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Nzw9v-0002jJ-2N for emacs-devel@gnu.org; Thu, 08 Apr 2010 20:08:55 +0200 Original-Received: from 226.red-81-33-105.dynamicip.rima-tde.net ([81.33.105.226]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 08 Apr 2010 20:08:55 +0200 Original-Received: from ofv by 226.red-81-33-105.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 08 Apr 2010 20:08:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 226.red-81-33-105.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:7tMEnS4iUcJ/alKr/6Uhyh8kgl0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123356 Archived-At: Óscar Fuentes writes: > "Jan D." writes: > >> ------------------------------------------------------------ >> revno: 99850 [merge] >> committer: Jan D. >> branch nick: trunk >> timestamp: Thu 2010-04-08 18:21:25 +0200 >> message: >> Lucid menus can now use Xft for fonts. >> >> * xsettings.c (current_font, SYSTEM_FONT, XSETTINGS_FONT_NAME): New. >> (parse_xft_settings): Also check for XSETTINGS_FONT_NAME and save that >> in current_font. >> (init_gconf): Read value of SYSTEM_FONT and save it in current_font. > > [snip] > > This change breaks the build for me. > > #define XSETTINGS_FONT_NAME is within a #ifdef HAVE_GCONF ... #endif but > it is used without that condition. This is a KDE machine, so HAVE_GCONF > is undefined here. (I'll love to see nice fonts on menus, though ;-) BTW, moving the #define XSETTINGS_FONT_NAME "Gtk/FontName" outside the #ifdef HAVE_GCONF ... #endif fixes the build. The menus now look great. Thanks!