From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: support for git commit --amend/--signoff Date: Fri, 11 Jun 2010 22:27:57 +0300 Organization: JURTA Message-ID: <87iq5ptu73.fsf@mail.jurta.org> References: <87hblavx6f.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276284653 28117 80.91.229.12 (11 Jun 2010 19:30:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 11 Jun 2010 19:30:53 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 11 21:30:51 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ON9wJ-0004pJ-I5 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 21:30:51 +0200 Original-Received: from localhost ([127.0.0.1]:39749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON9wJ-0006SH-06 for ged-emacs-devel@m.gmane.org; Fri, 11 Jun 2010 15:30:51 -0400 Original-Received: from [140.186.70.92] (port=44447 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ON9wC-0006SC-Ub for emacs-devel@gnu.org; Fri, 11 Jun 2010 15:30:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ON9wB-0000E4-Qr for emacs-devel@gnu.org; Fri, 11 Jun 2010 15:30:44 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4]:42816 helo=mx2.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ON9wA-0000DR-3L; Fri, 11 Jun 2010 15:30:42 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.28.166.cable.starman.ee [82.131.28.166]) by mx2.starman.ee (Postfix) with ESMTP id 9903C3F4092; Fri, 11 Jun 2010 22:30:37 +0300 (EEST) In-Reply-To: (Stefan Monnier's message of "Fri, 11 Jun 2010 10:18:34 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125759 Archived-At: > If we only consider Git's and DaRCS's forms of amend, I'd say that the > "Amend:" header might be a good approach, and that it should specify the > revision/patch that's amended. So for Git, you could have a command > that inserts "Amend: " and then the backend could check that the > SHA-1 is the right one (which would avoid accidental use). A more general variant would be a header that allows to specify command line arguments like Arguments: --amend --signoff This will provide interchangeability: the user will be able to copy arguments from the *VC-log* buffer to the external command line and back to the *VC-log* buffer to construct the necessary command line. -- Juri Linkov http://www.jurta.org/emacs/