From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kan-Ru Chen Newsgroups: gmane.emacs.devel Subject: Re: [RFC] Review uuid.el -- library for UUID generation Date: Sun, 14 Nov 2010 15:08:54 +0800 Message-ID: <87iq00s7p5.fsf@anar.kanru.info> References: <87r5evqgw5.fsf@anar.kanru.info> <87oc9tmabv.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289718569 8238 80.91.229.12 (14 Nov 2010 07:09:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 14 Nov 2010 07:09:29 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 14 08:09:25 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PHWiK-0000u4-Pl for ged-emacs-devel@m.gmane.org; Sun, 14 Nov 2010 08:09:24 +0100 Original-Received: from localhost ([127.0.0.1]:40021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHWiK-0008SH-1c for ged-emacs-devel@m.gmane.org; Sun, 14 Nov 2010 02:09:24 -0500 Original-Received: from [140.186.70.92] (port=42561 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHWiB-0008PV-2z for emacs-devel@gnu.org; Sun, 14 Nov 2010 02:09:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHWi6-00012H-Ur for emacs-devel@gnu.org; Sun, 14 Nov 2010 02:09:15 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:32994) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHWi6-000124-PI for emacs-devel@gnu.org; Sun, 14 Nov 2010 02:09:10 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PHWi2-0000lq-HX for emacs-devel@gnu.org; Sun, 14 Nov 2010 08:09:06 +0100 Original-Received: from 61-228-155-230.dynamic.hinet.net ([61.228.155.230]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Nov 2010 08:09:06 +0100 Original-Received: from kanru by 61-228-155-230.dynamic.hinet.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 14 Nov 2010 08:09:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 61-228-155-230.dynamic.hinet.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:MlPdn3qeRGDnKXFebC+oJz58ACg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132610 Archived-At: Chong Yidong writes: > Kan-Ru Chen writes: > >> I recently started a new library project, uuid-el, for generating UUIDs >> for RSS feeds, or other places where UUID are used. Since this is my >> first serious elisp program--a relatively simple one though--I'd like to >> take the chance to improve the code and to learn some conventions. > > Pretty good for a first elisp program. I don't see any convention > violations. Just one minor nitpick: > > (let ((address (uuid-get-ieee-address))) > (mapconcat (lambda (var) (format "%02x" var)) > address "") > )) > > Try not to leave close parentheses on lines by themselves; this tends to > annoy Lisp programmers. Thank you. I've put the updated version on github. Newer version uses `calc' package for bignum arithmetic, which should work on more platform. The only concern I have now is that the `network-interface-list' and `network-interface-info' aren't widely implemented or implemented correctly. For example, only Linux version of `network-interface-info' will return non-nil HWADDR. -- A badly written book is only a blunder. A bad translation of a good book is a crime. -- Gilbert Highet