From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Haselwarter Newsgroups: gmane.emacs.devel Subject: Re: Eliminating a couple of independent face definitions Date: Wed, 02 Feb 2011 21:33:37 +0100 Message-ID: <87ipx289cu.fsf@nzebook.haselwarter.org> References: <87oc6vm67v.fsf@stupidchicken.com> <87vd12z77n.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1296681073 10418 80.91.229.12 (2 Feb 2011 21:11:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 2 Feb 2011 21:11:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 02 22:11:09 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pkjxh-00066C-Qo for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2011 22:11:08 +0100 Original-Received: from localhost ([127.0.0.1]:41348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkjxI-0000ki-17 for ged-emacs-devel@m.gmane.org; Wed, 02 Feb 2011 16:09:36 -0500 Original-Received: from [140.186.70.92] (port=38957 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkjOp-0002bR-V6 for emacs-devel@gnu.org; Wed, 02 Feb 2011 15:34:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkjOj-0001BR-S5 for emacs-devel@gnu.org; Wed, 02 Feb 2011 15:33:55 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:49752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkjOj-0001BD-MR for emacs-devel@gnu.org; Wed, 02 Feb 2011 15:33:53 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PkjOg-0002Yq-Cd for emacs-devel@gnu.org; Wed, 02 Feb 2011 21:33:50 +0100 Original-Received: from mna75-3-89-83-43-131.dsl.club-internet.fr ([89.83.43.131]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Feb 2011 21:33:50 +0100 Original-Received: from philipp.haselwarter by mna75-3-89-83-43-131.dsl.club-internet.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 02 Feb 2011 21:33:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: mna75-3-89-83-43-131.dsl.club-internet.fr X-NSA-Fodder: Kh-11 Noriega Hamas Israel afsatcom electronic surveillance X-Flame: I couldn't care less about your bug fix. User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:OhgQyv4BpKPD08lNPWI0pJ1Z4rE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135485 Archived-At: "CY" == Chong Yidong writes: CY> Tim Cross writes: >> My only concern is how you define what to inherit from. For example, >> in your suggestion of compiler warnings inheriting form >>  font-lock-comment-face I immediately wondered why you would not >> inherit from font-lock-warning face? CY> font-lock-warning-face is already used for compilation errors, which CY> are more serious than warnings. Why not have a font-lock-warning face and a font-lock-error face? I think some more reasonably named generic fonts to pick from would make theming a lot easier. As Drew said, faces need to make sense in their context. I just spent some time picking sensible faces from the font-lock-* palette for dired+, which by default defines its own static faces. Most themes don't address these, resulting in readability issues. I ended up with a nice looking setup, but the face names make no sense *at all* in their context. Some generic faces, that could guarantee some extend of contrast between them would make consistency much easier. -- Philipp Haselwarter