unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergio Durigan Junior <sergiodj@riseup.net>
To: emacs-devel@gnu.org
Subject: [PATCH] Fix bug #11580
Date: Fri, 21 Sep 2012 23:40:42 -0300	[thread overview]
Message-ID: <87ipb64w5x.fsf@riseup.net> (raw)

Hi,

The attached patch fixes the bug listed on $SUBJECT.  Maybe there are
better ways to fix it, but a quick hack did the trick so I am sending it
for review.

It is the first time I contribute to Emacs, so I don't know if should
post this patch elsewhere.  I would be glad to receive feedback about
it.

Thank you,

-- 
Sergio

2012-09-22  Sergio Durigan Junior  <sergiodj@riseup.net>

	* net/eudcb-bbdb.el (eudc-bbdb-format-record-as-result): Do not
	treat empty strings.  (Bug#11580).

=== modified file 'lisp/net/eudcb-bbdb.el'
--- lisp/net/eudcb-bbdb.el	2012-01-19 07:21:25 +0000
+++ lisp/net/eudcb-bbdb.el	2012-09-22 02:15:16 +0000
@@ -167,7 +167,7 @@
 			 'record))))
        (t
 	(setq val "Unknown BBDB attribute")))
-      (if val
+      (if (and val (or (listp val) (not (string= val ""))))
 	(cond
 	 ((memq attr '(phones addresses))
 	  (setq eudc-rec (append val eudc-rec)))




             reply	other threads:[~2012-09-22  2:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-22  2:40 Sergio Durigan Junior [this message]
2012-09-26 17:54 ` [PATCH] Fix bug #11580 Tassilo Horn
2012-09-26 18:18   ` Sergio Durigan Junior
2012-09-26 18:56     ` bug#11580: " Tassilo Horn
     [not found] ` <87mx0c655g.fsf__10545.1882271611$1348682125$gmane$org@thinkpad.tsdh.de>
2012-09-29 12:04   ` Roland Winkler
2012-09-29 19:30     ` Sergio Durigan Junior
2012-09-30 15:12       ` Roland Winkler
2012-10-02  1:46         ` Sergio Durigan Junior
2012-10-02  3:59           ` Stefan Monnier
2012-10-02  5:10           ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipb64w5x.fsf@riseup.net \
    --to=sergiodj@riseup.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).