unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Le Wang <l26wang@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: flx -- flex with better sorting
Date: Wed, 01 May 2013 18:04:52 +0200	[thread overview]
Message-ID: <87ip32ofdn.fsf@wanadoo.es> (raw)
In-Reply-To: <CAM=K+ipWqp_iN5ZW5DEk9+gUTACPXAtJVW8wnkvu-JCgxP5FNw@mail.gmail.com> (Le Wang's message of "Wed, 1 May 2013 23:01:13 +0800")

Le Wang <l26wang@gmail.com> writes:

> I've put up my implementation of Sublime Text 2's fuzzy matching -- i.e.
> ido's flex with superior sorting. https://github.com/lewang/flx
>
> I've made a screencast (5 min) of rationale and workflow.
> http://www.youtube.com/watch?v=_swuJ1RuMgk
>
> I have signed assignment papers, and would be willing to contribute it to
> Emacs.  So please check it out and point out any inefficiencies in my
> algorithms.

From trying it for a few minutes with ido:

1. I like it. Looks much better that ido's flex matching.

2. Working with 10500 candidate files, there is a noticeable pause the
   first time ido-complete is invoked. I'm using a reasonably fast
   machine and the pause is not annoying, but that perception may change
   when using less capable machines.

3. With the same set of candidates, RES memory jumps from 35 MB to 70 MB
   on first use (on a 64 bit GNU/Linux machine). This is a more serious
   concern.

4. Sometimes it fails to work as advertised. For instance, if I type
   `ltx' this file is shown first on the list of matches:

lib/Target/NVPTX/NVPTXLowerAggrCopies.h

but I would expect

lib/Target/X86/* (* meaning any file under that subdirectory).

Furthermore, when inputting `ltx8', matching letters on candidates are
highlighted like this:

lib/Target/X86/X86TargetTransformInfo.cpp
^   ^          ^^

It ignores the first occurrence of `X8'.

5. Another quirk is that it rejects capital letters. For instance, if I
   type `lT' it shows no matches, but in fact there are lots of files
   like this:

lib/Target/...

Actually, typing just `T' fails to find any candidate, but there are
lots files with a capital T on its name.



  reply	other threads:[~2013-05-01 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 15:01 flx -- flex with better sorting Le Wang
2013-05-01 16:04 ` Óscar Fuentes [this message]
2013-05-01 16:26   ` Le Wang
2013-05-01 17:04     ` Óscar Fuentes
2013-05-01 17:27       ` Le Wang
2013-05-01 18:16         ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip32ofdn.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=emacs-devel@gnu.org \
    --cc=l26wang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).