From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Claudio Bley Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5 Date: Tue, 29 Oct 2013 09:44:01 +0100 Message-ID: <87iowgv54e.wl%claudio.bley@gmail.com> References: <87y55he51l.wl%claudio.bley@gmail.com> <83hac2fzkl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1383036262 22677 80.91.229.3 (29 Oct 2013 08:44:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Oct 2013 08:44:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 29 09:44:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vb4uW-0006X8-Sf for ged-emacs-devel@m.gmane.org; Tue, 29 Oct 2013 09:44:24 +0100 Original-Received: from localhost ([::1]:45318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vb4uW-0000g2-IZ for ged-emacs-devel@m.gmane.org; Tue, 29 Oct 2013 04:44:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vb4uO-0000fx-2y for emacs-devel@gnu.org; Tue, 29 Oct 2013 04:44:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vb4uI-0007kF-OO for emacs-devel@gnu.org; Tue, 29 Oct 2013 04:44:16 -0400 Original-Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:45580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vb4uC-0007gq-SW; Tue, 29 Oct 2013 04:44:05 -0400 Original-Received: by mail-ee0-f51.google.com with SMTP id d41so3872236eek.24 for ; Tue, 29 Oct 2013 01:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; bh=e16m38wkjE2GYOCZBNF3cxkMwOq4wsBZYCaxyl+Awf4=; b=as7dNfQkgKax5qdva1AzSedu63zFgecL+R4RK3x8nJHOCf1XsGv/3VDUSYYP4dWdW5 5K78HW/b5jzeAZsJsHDQisOWFxLyoDtcSNeQDuHfsPXi5r8DChtkNMjaJ4SO8nR740X+ yU0d+P4KKzl1EBtzsefpV1XBtU656uAdb+UYN5TnUgwwZSNDSp+87CsM+ENkhoYvHfXB puftixBcImoqVjdL1pzxF2U/EAUmgPJken0uYelZy/RQbBKfSIZ66lsbnjRl5eHFrUFc g21adefjnob7UT0JANFXZH8oiO2ypcd8h3ORmbDOD1n5UA9bS7L6rAh6RW1QS24EXz6V otgw== X-Received: by 10.14.178.67 with SMTP id e43mr6728159eem.59.1383036243675; Tue, 29 Oct 2013 01:44:03 -0700 (PDT) Original-Received: from CLAUDIO-PC.localdomain.de (178-24-125-95-dynip.superkabel.de. [178.24.125.95]) by mx.google.com with ESMTPSA id a6sm67497170eei.10.2013.10.29.01.44.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2013 01:44:03 -0700 (PDT) In-Reply-To: <83hac2fzkl.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3.50 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164616 Archived-At: At Sun, 27 Oct 2013 18:28:26 +0200, Eli Zaretskii wrote: > > Here, too, latest libpng versions are incompatible with 1.4.x, so we > do need to make such a change. > > However, when one builds libpng-X.Y.Z on Windows, the DLL that is > installed is called libpngXY-XY.dll, not just libpngXY.dll, as your > patch assumes. I'm building with CMake and that's what the CMake builds produce. If you download the release tarball (lpng166.7z) for win32, the DLL produced is also called libpng16.dll. > I don't mind supporting both forms, but we must support the form > used by "make install" in the libpng distribution. > > So could you please modify this patch accordingly? OK, I'll add libpngXY-XY.dll as a second alternative, since libpngXY.dll seems to be the platform default.