From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add support for custom user agent strings in url.el Date: Sun, 19 Jan 2014 14:06:58 +0530 Message-ID: <87iotg5pw5.fsf@cthulhu-p5kpl.lan> References: <87k3dw5r44.fsf@cthulhu-p5kpl.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390120639 28100 80.91.229.3 (19 Jan 2014 08:37:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jan 2014 08:37:19 +0000 (UTC) Cc: Vibhav Pant , emacs-devel To: "Bozhidar Batsov" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 19 09:37:26 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W4nsj-0002ol-J1 for ged-emacs-devel@m.gmane.org; Sun, 19 Jan 2014 09:37:25 +0100 Original-Received: from localhost ([::1]:45510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4nsi-0000nt-Pi for ged-emacs-devel@m.gmane.org; Sun, 19 Jan 2014 03:37:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4nsY-0000mm-5N for emacs-devel@gnu.org; Sun, 19 Jan 2014 03:37:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4nsP-0007TU-Ol for emacs-devel@gnu.org; Sun, 19 Jan 2014 03:37:14 -0500 Original-Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:51673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4nsP-0007TP-GK for emacs-devel@gnu.org; Sun, 19 Jan 2014 03:37:05 -0500 Original-Received: by mail-pd0-f180.google.com with SMTP id x10so4374243pdj.39 for ; Sun, 19 Jan 2014 00:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:user-agent:in-reply-to:date :message-id:mime-version:content-type; bh=OHJzINoSB+TqQPi9fs6oqKuFZ8WVZmnEXFU+94EeBwA=; b=UOgUE9jCEJjVmc2kcKWU7GbstKW7ozgGUkQYl24LJ8vPoHnXI2ojLVvRW6NLVEZRpS 6FHcW1IfpnJI8cyQCGhwsa0X3iuq1Yhwnal958XyH6jL/LJhqzLtfIn74tYq7X0Efxoz rvZsoVFNpqs2r8zMU6+Z7+IaHBJKVmx0WwzKK7NTmZwsZfHsuDeBMX+8swwoqslf6Ek8 GJX1NY8oQOzaxG9mET40IV9V2HCwq4tua5OLs6GkZg2yz/T4KCj0AkoNhMfkZe2Bm+DF jjPvuQQASb9Y7BbL9SKVeC5uuh9j4UcvTHitDf6wqiSsSTffMkQdyJIxPC5KAMC9XZ78 3ZHw== X-Received: by 10.68.24.193 with SMTP id w1mr12235315pbf.78.1390120624402; Sun, 19 Jan 2014 00:37:04 -0800 (PST) Original-Received: from cthulhu-p5kpl.lan ([117.201.82.142]) by mx.google.com with ESMTPSA id g6sm49927205pat.2.2014.01.19.00.37.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jan 2014 00:37:03 -0800 (PST) User-agent: mu4e 0.9.9.5; emacs 24.3.50.1 In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168726 Archived-At: Bozhidar Batsov writes: > Seems to me that there should be just a defcustom `url-user-agent' and it > should be used always. By default it should have whatever value it > currently has and users will be able to customise it. The function url-http-user-agent-string generates a user agent by concatinating url-package-name and url-package-version. So the defcustom would have to be a function or a sexp, making things a little confusing for new users. -- Vibhav Pant vibhavp@gmail.com