From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan Nieuwenhuizen Newsgroups: gmane.lisp.guile.user,gmane.emacs.devel Subject: Re: [PATCH 1/3] Support Guile backtraces in compilation mode. Date: Fri, 08 Aug 2014 19:43:00 +0200 Organization: AvatarAcademy.nl Message-ID: <87iom2513v.fsf@drakenvlieg.flower> References: <1407495956-20322-1-git-send-email-janneke@gnu.org> <1407495956-20322-2-git-send-email-janneke@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1407521346 11302 80.91.229.3 (8 Aug 2014 18:09:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Aug 2014 18:09:06 +0000 (UTC) Cc: guile-user , emacs-devel To: Stefan Monnier Original-X-From: guile-user-bounces+guile-user=m.gmane.org@gnu.org Fri Aug 08 20:09:01 2014 Return-path: Envelope-to: guile-user@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XFob0-0007qY-La for guile-user@m.gmane.org; Fri, 08 Aug 2014 20:08:54 +0200 Original-Received: from localhost ([::1]:52412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFoaz-000773-Sa for guile-user@m.gmane.org; Fri, 08 Aug 2014 14:08:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFoCF-0008T0-N1 for guile-user@gnu.org; Fri, 08 Aug 2014 13:43:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFoCA-0007eF-Qp for guile-user@gnu.org; Fri, 08 Aug 2014 13:43:19 -0400 Original-Received: from smtp-vbr12.xs4all.nl ([194.109.24.32]:2179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFoC0-0007bs-PA; Fri, 08 Aug 2014 13:43:05 -0400 Original-Received: from drakenvlieg.flower.peder.onsbrabantnet.nl (peder.onsbrabantnet.nl [88.159.206.46]) (authenticated bits=0) by smtp-vbr12.xs4all.nl (8.13.8/8.13.8) with ESMTP id s78Hh1Ux015905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Aug 2014 19:43:02 +0200 (CEST) (envelope-from janneke@gnu.org) X-Url: http://AvatarAcademy.nl In-Reply-To: (Stefan Monnier's message of "Fri, 08 Aug 2014 09:29:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 194.109.24.32 X-BeenThere: guile-user@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: General Guile related discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-user-bounces+guile-user=m.gmane.org@gnu.org Original-Sender: guile-user-bounces+guile-user=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.user:11389 gmane.emacs.devel:173486 Archived-At: Stefan Monnier writes: > Quick comments: > - You can collapse all three patches into a single one. Done. > - Both of those Guile regexps are much too generic (i.e. likely to > appear in non-Guile output), while the corresponding handler you > provide is clearly very Guile-specific. This is a *serious* problem. Yes, I see your point. I have removed the code for to get at the absolute file name > - I think a good way to solve it would be to push the problem upstream > ;-) and will try to get that bit moved upstream. :-) > IOW, convince the Guile guys to follow the GNU convention. This could > look somewhat like: > * Guile backtraces >=20=20=20=20 > Backtrace: > /some/where/ice-9/boot-9.scm:157: > 6 [catch #t # ...] Sure. Finding ice-9/boot-9.scm etc will have to be done by the user until this is changed in Guile. > /home/janneke/vc/guile/examples/gud-break.scm:1038: but the bits in most user code should work. > With the above, you might not even need to change compile.el. Yes, I'm trying another, much simpler, incarnation of this patch for all the guile versions that are in the field right now, and will be for many years to come. > Tho, > admittedly, the above lines might end up highlighted as "errors" > whereas they should probably be treated as "info", so some annotation > on the "FILE:LINE:" lines would be helpful to let Emacs know that it's > not an "error" location, but just an "info". Not sure if the GNU > conventions already include such an annotation, but I can't see why > that couldn't be arranged. That would be nice too. We'll see where this goes. Thanks! Greetings, Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20