Re: [PATCH 1/3] Support Guile backtraces in compilation mode.

[Jan Nieuwenhuizen <janneke@gnu.org>]

Stefan Monnier writes:

> Quick comments:
> - You can collapse all three patches into a single one.

Done.

> - Both of those Guile regexps are much too generic (i.e. likely to
>   appear in non-Guile output), while the corresponding handler you
>   provide is clearly very Guile-specific.  This is a *serious* problem.

Yes, I see your point.  I have removed the code for to get at the
absolute file name

> - I think a good way to solve it would be to push the problem upstream
> ;-)

and will try to get that bit moved upstream. :-)

>   IOW, convince the Guile guys to follow the GNU convention.  This could
>   look somewhat like:

>    * Guile backtraces
>    
>    Backtrace:
>    /some/where/ice-9/boot-9.scm:157:
>       6 [catch #t #<catch-closure 196e3e0> ...]

Sure.  Finding ice-9/boot-9.scm etc will have to be done by the user
until this is changed in Guile.

>    /home/janneke/vc/guile/examples/gud-break.scm:1038:

but the bits in most user code should work.

>   With the above, you might not even need to change compile.el.

Yes, I'm trying another, much simpler, incarnation of this patch
for all the guile versions that are in the field right now, and
will be for many years to come.

>   Tho,
>   admittedly, the above lines might end up highlighted as "errors"
>   whereas they should probably be treated as "info", so some annotation
>   on the "FILE:LINE:" lines would be helpful to let Emacs know that it's
>   not an "error" location, but just an "info".  Not sure if the GNU
>   conventions already include such an annotation, but I can't see why
>   that couldn't be arranged.

That would be nice too.  We'll see where this goes.

Thanks!  Greetings, Jan

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl