From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Dima Kogan <dima@secretsauce.net>
Subject: Re: master 127bafd: Fix setting breakpoints when remote-debugging
Date: Mon, 21 Sep 2015 14:36:17 +0200 [thread overview]
Message-ID: <87io74q79a.fsf@gmx.de> (raw)
In-Reply-To: <E1Zdykn-0007BO-5u@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Mon, 21 Sep 2015 10:55:25 +0000")
Eli Zaretskii <eliz@gnu.org> writes:
> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
> index 9ab0667..8b5d490 100644
> --- a/lisp/progmodes/gud.el
> +++ b/lisp/progmodes/gud.el
> @@ -2855,6 +2855,11 @@ Obeying it means displaying in another window the specified file and line."
> (defun gud-format-command (str arg)
> (let ((insource (not (eq (current-buffer) gud-comint-buffer)))
> (frame (or gud-last-frame gud-last-last-frame))
> + (buffer-file-name-localized
> + (if (and (buffer-file-name) (file-remote-p (buffer-file-name)))
> + (tramp-file-name-localname (tramp-dissect-file-name
> + (buffer-file-name) t))
> + (buffer-file-name)))
Better would be
(buffer-file-name-localized
(and (buffer-file-name)
(or (file-remote-p (buffer-file-name) 'localname)
(buffer-file-name))))
Tramp internal function calls shall be avoided.
Best regards, Michael.
next parent reply other threads:[~2015-09-21 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150921105525.27576.92526@vcs.savannah.gnu.org>
[not found] ` <E1Zdykn-0007BO-5u@vcs.savannah.gnu.org>
2015-09-21 12:36 ` Michael Albinus [this message]
2015-09-21 18:35 ` master 127bafd: Fix setting breakpoints when remote-debugging Dima Kogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io74q79a.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=dima@secretsauce.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).