From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: fix/ert-multiline-explanation Date: Fri, 23 Oct 2015 10:02:46 +0100 Message-ID: <87io5y9cuh.fsf@russet.org.uk> References: <871tco2brx.fsf@russet.org.uk> <87eggoymmj.fsf@fencepost.gnu.org> <878u6vnvgb.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445591013 20001 80.91.229.3 (23 Oct 2015 09:03:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 09:03:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 23 11:03:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpYFl-00046m-EB for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 11:03:13 +0200 Original-Received: from localhost ([::1]:37086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpYFk-0004GO-JC for ged-emacs-devel@m.gmane.org; Fri, 23 Oct 2015 05:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpYFV-0004F1-W5 for emacs-devel@gnu.org; Fri, 23 Oct 2015 05:03:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpYFV-00041x-1Z for emacs-devel@gnu.org; Fri, 23 Oct 2015 05:02:57 -0400 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:53673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpYFP-00040S-Hj; Fri, 23 Oct 2015 05:02:51 -0400 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1ZpYFK-0004B1-Fi; Fri, 23 Oct 2015 10:02:46 +0100 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZpYFK-0005s0-Kt; Fri, 23 Oct 2015 10:02:46 +0100 In-Reply-To: <878u6vnvgb.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 22 Oct 2015 09:44:52 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192464 Archived-At: Phillip Lord writes: > David Kastrup writes: > >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >>> I would appreciate feedback on whether the change on >>> fix/ert-multiline-explanation would be a good one. >>> >>> At the moment, ert allows you to attach explanation functions to explain >>> why tests have failed. Unfortunately, these explanations are printed out >>> using "pp" which escapes new lines. So multiline explanations are, >>> largely, unreadable. >>> >>> So this patch ignores the value of pp-escape-newlines and resets it to >>> nil for the duration. >> >> This patch? > > On the branch fix/ert-multiline-explanation. > > a23aa4c9c99147bd6f36941fbae3a2d94c481bed > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=fix/ert-multiline-explanation&id=a23aa4c9c99147bd6f36941fbae3a2d94c481bed > > Never really understood patches. Branches or request pull/pull > request/merge request seem much easier. Any comments? Phil