unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: phillip.lord@russet.org.uk (Phillip Lord)
To: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: fix/ert-multiline-explanation
Date: Fri, 23 Oct 2015 10:02:46 +0100	[thread overview]
Message-ID: <87io5y9cuh.fsf@russet.org.uk> (raw)
In-Reply-To: <878u6vnvgb.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 22 Oct 2015 09:44:52 +0100")

Phillip Lord <phillip.lord@russet.org.uk> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> phillip.lord@russet.org.uk (Phillip Lord) writes:
>>
>>> I would appreciate feedback on whether the change on
>>> fix/ert-multiline-explanation would be a good one.
>>>
>>> At the moment, ert allows you to attach explanation functions to explain
>>> why tests have failed. Unfortunately, these explanations are printed out
>>> using "pp" which escapes new lines. So multiline explanations are,
>>> largely, unreadable.
>>>
>>> So this patch ignores the value of pp-escape-newlines and resets it to
>>> nil for the duration.
>>
>> This patch?
>
> On the branch fix/ert-multiline-explanation. 
>
> a23aa4c9c99147bd6f36941fbae3a2d94c481bed
>
> http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=fix/ert-multiline-explanation&id=a23aa4c9c99147bd6f36941fbae3a2d94c481bed
>
> Never really understood patches. Branches or request pull/pull
> request/merge request seem much easier.

Any comments?

Phil



  reply	other threads:[~2015-10-23  9:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 20:43 fix/ert-multiline-explanation Phillip Lord
2015-10-21 20:47 ` fix/ert-multiline-explanation David Kastrup
2015-10-22  8:44   ` fix/ert-multiline-explanation Phillip Lord
2015-10-23  9:02     ` Phillip Lord [this message]
2015-10-24 14:45       ` fix/ert-multiline-explanation David Engster
2015-10-26  8:52         ` fix/ert-multiline-explanation Phillip Lord
2015-10-24 15:11 ` fix/ert-multiline-explanation Eli Zaretskii
2015-10-26  8:55   ` fix/ert-multiline-explanation Phillip Lord
2015-10-26 15:57     ` fix/ert-multiline-explanation Eli Zaretskii
2015-10-27 12:46       ` fix/ert-multiline-explanation Phillip Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io5y9cuh.fsf@russet.org.uk \
    --to=phillip.lord@russet.org.uk \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).