From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 f5c762c: Additional changes for "make check-expensive" Date: Tue, 12 Jan 2016 17:43:18 +0000 Message-ID: <87io2y66dl.fsf@russet.org.uk> References: <20160105084751.30334.99051@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452620621 31775 80.91.229.3 (12 Jan 2016 17:43:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jan 2016 17:43:41 +0000 (UTC) Cc: Michael Albinus To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 12 18:43:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJ2yj-0002eu-2t for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 18:43:33 +0100 Original-Received: from localhost ([::1]:33451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ2yi-0005P7-GY for ged-emacs-devel@m.gmane.org; Tue, 12 Jan 2016 12:43:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ2yd-0005MB-O1 for emacs-devel@gnu.org; Tue, 12 Jan 2016 12:43:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJ2yZ-0001lk-NP for emacs-devel@gnu.org; Tue, 12 Jan 2016 12:43:27 -0500 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:45916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJ2yZ-0001l9-H5 for emacs-devel@gnu.org; Tue, 12 Jan 2016 12:43:23 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1aJ2yV-0007Xp-Cu; Tue, 12 Jan 2016 17:43:19 +0000 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1aJ2yU-0007Td-Q5; Tue, 12 Jan 2016 17:43:18 +0000 In-Reply-To: (Michael Albinus's message of "Tue, 5 Jan 2016 08:47:51 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198095 Archived-At: Michael Albinus writes: > diff --git a/test/automated/Makefile.in b/test/automated/Makefile.in > index 43e3905..48920ef 100644 > --- a/test/automated/Makefile.in > +++ b/test/automated/Makefile.in > @@ -87,9 +87,9 @@ WRITE_LOG = > $@ 2>&1 || { stat=ERROR; cat $@; }; echo $$stat: $@ > ## to change this; bug#17848 - if that gets done, this can be simplified). > ## > ## Beware: it approximates 'no-byte-compile', so watch out for false-positives! > -SELECTOR_DEFAULT=(not (tag :expensive-test)) > +SELECTOR_DEFAULT=(quote (not (tag :expensive-test))) > SELECTOR_EXPENSIVE=nil > -SELECTOR=${SELECTOR_DEFAULT} > +SELECTOR= Michael I think that there is a problem with this commit, in that the default selector is only used for "make check". By default "make check-maybe" runs all tests (including the expensive ones). So, you have to do make check-maybe SELECTOR="(quote (not (tag :expensive-test)))" I think it makes more sense for check-maybe to skip expensive tests, unless told otherwise, as "make check-maybe" is a good candidate for use pre-commit. Something like this should work: SELECTOR_DEFAULT=(quote (not (tag :expensive-test))) SELECTOR_EXPENSIVE=nil SELECTOR= ifeq ($(SELECTOR),undefined) SELECTOR_ACTUAL=$(SELECTOR_DEFAULT) else SELECTOR_ACTUAL=$(SELECTOR) endif (and changing all subsequent uses of SELECTOR to SELECTOR_ACTUAL). which would preserve the use of "SELECTOR" for use on the command line. Make sense? (er, pun not intended). Phil