From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Marcin Borkowski Newsgroups: gmane.emacs.devel Subject: Re: Font height issue Date: Thu, 25 Feb 2016 20:49:00 +0100 Message-ID: <87io1cvadv.fsf@mbork.pl> References: <87oab4fusj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456429787 24158 80.91.229.3 (25 Feb 2016 19:49:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Feb 2016 19:49:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 25 20:49:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZ1uq-00035p-KS for ged-emacs-devel@m.gmane.org; Thu, 25 Feb 2016 20:49:36 +0100 Original-Received: from localhost ([::1]:45505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ1up-000709-QA for ged-emacs-devel@m.gmane.org; Thu, 25 Feb 2016 14:49:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ1uT-0006zc-Bx for emacs-devel@gnu.org; Thu, 25 Feb 2016 14:49:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ1uP-0004f2-VE for emacs-devel@gnu.org; Thu, 25 Feb 2016 14:49:13 -0500 Original-Received: from mail.mojserwer.eu ([2a01:5e00:2:52::8]:46511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ1uP-0004e3-Nt for emacs-devel@gnu.org; Thu, 25 Feb 2016 14:49:09 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 4E32C9D2005; Thu, 25 Feb 2016 20:49:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Original-Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1bIGyXfvuDWq; Thu, 25 Feb 2016 20:49:01 +0100 (CET) Original-Received: from localhost (unknown [109.232.24.28]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 0F0C39D2004; Thu, 25 Feb 2016 20:49:01 +0100 (CET) User-agent: mu4e 0.9.13; emacs 25.1.50.3 In-reply-to: <87oab4fusj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:5e00:2:52::8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200673 Archived-At: On 2016-02-25, at 20:34, Tassilo Horn wrote: > Hi all, > > I have the problem that the font I want to use in Emacs (PragmataPro in > size 10, sizes 9 or 11 seem to be not affected) seems to have slightly > different heights in the regular and the bold version, or at least Emacs > thinks so. As a result, when modes change text to/from regular to bold > or vice versa dynamically (e.g., show-paren-mode with a bold > show-paren-match face), the height of the line changes which is > extremely annoying. > > When I searched the net I found many others having this kind of issue > with different fonts (like DejaVu Sans Mono), too, and I also found this > workaround > > https://www.reddit.com/r/emacs/comments/3zto22/i_sort_of_fixed_a_font_rendering_bug_of_emacs/ > > suggesting this patch: > > --8<---------------cut here---------------start------------->8--- > diff --git a/src/xftfont.c b/src/xftfont.c > index 110f99a..95e7e52 100644 > --- a/src/xftfont.c > +++ b/src/xftfont.c > @@ -395,16 +395,16 @@ xftfont_open (struct frame *f, Lisp_Object entity, int pixel_size) > > font->ascent = xftfont->ascent; > font->descent = xftfont->descent; > - if (pixel_size >= 5) > - { > - /* The above condition is a dirty workaround because > - XftTextExtents8 behaves strangely for some fonts > - (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. */ > - if (font->ascent < extents.y) > - font->ascent = extents.y; > - if (font->descent < extents.height - extents.y) > - font->descent = extents.height - extents.y; > - } > + /* if (pixel_size >= 5) */ > + /* { */ > + /* /\* The above condition is a dirty workaround because */ > + /* XftTextExtents8 behaves strangely for some fonts */ > + /* (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. *\/ */ > + /* if (font->ascent < extents.y) */ > + /* font->ascent = extents.y; */ > + /* if (font->descent < extents.height - extents.y) */ > + /* font->descent = extents.height - extents.y; */ > + /* } */ > font->height = font->ascent + font->descent; > > if (XINT (AREF (entity, FONT_SIZE_INDEX)) == 0) > --8<---------------cut here---------------end--------------->8--- > > And indeed, that does solve the issue for me. Now the regular and the > bold version are displayed with the same height. > > I have no idea about font handling, so I cannot tell if the above DTRT. > However, it fixes an annoying issue that seems to happen only with > Emacs. Somewhere on the net I've read that Emacs seems to be the only > one being correct, i.e., it displays what the font says, and if the bold > version of a font is higher than the regular one, that's a (mis)feature > of the font. > > Anyhow, since the results can be annoying and apparently not so few > users are affected, can we have a customize option for that? +1 I have the same problem. > Bye, > Tassilo Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University