From: Andreas Schwab <schwab@linux-m68k.org>
To: Ingo Lohmar <i.lohmar@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: handling of completion table duplicates
Date: Sun, 03 Apr 2016 16:34:41 +0200 [thread overview]
Message-ID: <87inzyzrpa.fsf@linux-m68k.org> (raw)
In-Reply-To: <87h9fiewnf.fsf@acer.localhost.com> (Ingo Lohmar's message of "Sun, 03 Apr 2016 13:53:24 +0200")
Ingo Lohmar <i.lohmar@gmail.com> writes:
> I recently noticed that ivy-mode (at its very core a completing-read
> alternative, just like ido-completing-read is another one) does *not*
> eliminate duplicates from the collection it is passed, eg, in form of a
> plain list.
>
> (completing-read "Prompt: " '("a" "b" "c" "a" "d"))
>
> Both completing-read as well as ido-completing-read remove such
> duplicates,
all-completions doesn't. The removal is probably just a side effect of
the implementation.
> Is removing duplicates from the collection *expected* from completion
> functions, or is the caller of the function responsible for providing a
> collection without duplicates?
IMHO it's the resposibility of the caller to make sure the completion
table is useful.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-04-03 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 11:53 handling of completion table duplicates Ingo Lohmar
2016-04-03 14:09 ` Stefan Monnier
2016-04-03 14:34 ` Andreas Schwab [this message]
2016-04-03 15:55 ` Drew Adams
2016-04-05 20:29 ` Ingo Lohmar
2016-04-05 21:42 ` Drew Adams
2016-04-06 17:28 ` Ingo Lohmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inzyzrpa.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=i.lohmar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).