From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Sat, 24 Dec 2016 22:52:42 -0800 Message-ID: <87inq8ec05.fsf@secretsauce.net> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> <9fe241fa-d4ee-6e44-bfdd-99cb6b4ab4e4@yandex.ru> <87fultr4he.fsf@secretsauce.net> <877f6v2vc1.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1482648826 13344 195.159.176.226 (25 Dec 2016 06:53:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2016 06:53:46 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 26.0.50.1 Cc: emacs-devel@gnu.org, Dmitry Gutov To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 25 07:53:38 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL2gW-0001X5-58 for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 07:53:32 +0100 Original-Received: from localhost ([::1]:45926 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL2gZ-0005e2-0b for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 01:53:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL2fr-0005dw-RZ for emacs-devel@gnu.org; Sun, 25 Dec 2016 01:52:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cL2fn-0001Jf-0S for emacs-devel@gnu.org; Sun, 25 Dec 2016 01:52:51 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46150) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cL2fm-0001JH-Sg for emacs-devel@gnu.org; Sun, 25 Dec 2016 01:52:46 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C1A0920909; Sun, 25 Dec 2016 01:52:44 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 25 Dec 2016 01:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=2ul wSSVKOWDlNqMbdESOj4gBK3g=; b=H9vOAaxf+sviEXZbITeU46pmOxXraRI0Zpn 7G9u0PbQqhMZzO4P3VSWPBMILVoDPdrvPD89OCThEt4b11xwrqzbkgSlkUcLlhYd ogHOqkCeskT7C/nEATCFpgIShFRfT01nJxoQXiBw0gAkuQttLWxsLQI2w2WAq9xQ J5F806jY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=2ulwSSVKOWDlNqMbdESOj4gBK3g=; b=jxXeCTqgic57Au4zbteh Jep3RjpBOdIEyaDWGJJPFPIJbk0pkrkDLoFDiWg3haV9ar+eTQQJWky/Pg7k28L8 rOmj/45pKadWBULh2Uwd0KxDpbiJwveKXhcM33faI0wVF06P6axXGRKuu4bvUU8S F2gWNsKTYRH0+1rgOJCvMKQ= X-ME-Sender: X-Sasl-enc: HOp5ek3HyrOjjqtEpF/OEYfBsZFJOCoMrkdhIWURULGa 1482648764 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A31B7E050; Sun, 25 Dec 2016 01:52:44 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1cL2fj-0003dD-0A; Sat, 24 Dec 2016 22:52:43 -0800 In-reply-to: <877f6v2vc1.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210798 Archived-At: Tino Calancha writes: > Hi Dima, > after commit 2c8a7e5 the following receipt doesn't work: > > M-! git show HEAD RET > C-x o > C-x C-q > M-x diff-mode RET > n > ;; Signal error: > diff-beginning-of-file-and-junk: Can t find the beginning of the file > > I use above code very often: before commit 2c8a7e5, it skips the commit > message and jumps to the first hunk. > Is it possible to make above snippet working as before? Hi. I pushed to master the fix to this and the logic to invoke the auto-refinement only if the preceding motion was successful.