From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook Date: Sun, 17 Sep 2017 14:37:35 -0700 Message-ID: <87inghnh0g.fsf@ericabrahamsen.net> References: <20170917193244.24537.24926@vcs0.savannah.gnu.org> <20170917193245.721F520AB5@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505684438 17807 195.159.176.226 (17 Sep 2017 21:40:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Sep 2017 21:40:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 17 23:40:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dthIl-0004HE-V7 for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 23:40:32 +0200 Original-Received: from localhost ([::1]:33758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dthIq-0007Mv-8X for ged-emacs-devel@m.gmane.org; Sun, 17 Sep 2017 17:40:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dthIb-0007MM-CR for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:40:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dthIX-0003ze-Ge for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:40:21 -0400 Original-Received: from [195.159.176.226] (port=39775 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dthIX-0003yu-A0 for emacs-devel@gnu.org; Sun, 17 Sep 2017 17:40:17 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dthIM-0003ZG-M7 for emacs-devel@gnu.org; Sun, 17 Sep 2017 23:40:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:5otgpOiHuG9ASYiroxgXD1J2tSA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218434 Archived-At: Stefan Monnier writes: >> +(defcustom ebdb-install-save-hook t >> + "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'." >> + :group 'ebdb-eieio >> + :type 'boolean) > > I think the docstring should talk about the intended effect from the > user's point of view, rather than from the implementation's point > of view. I'm not 100% sure what is the intended effect, but it seems to > be something like "automatically save EBDB when leaving Emacs". Yes, that's the intended effect. I'd originally had the `add-hook' at top level in ebdb-com.el, so loading the file added the hook. That led to `ebdb-save' being called when batch compiling and testing (ugh). I'll re-work the docstring. Thanks, Eric