Re: [elpa] externals/ebdb 4206ccd 02/21: Don't unilaterally add to kill-emacs-hook

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +(defcustom ebdb-install-save-hook t
>> +  "If non-nil, add `ebdb-save' to the hook `kill-emacs-hook'."
>> +  :group 'ebdb-eieio
>> +  :type 'boolean)
>
> I think the docstring should talk about the intended effect from the
> user's point of view, rather than from the implementation's point
> of view.  I'm not 100% sure what is the intended effect, but it seems to
> be something like "automatically save EBDB when leaving Emacs".

Yes, that's the intended effect. I'd originally had the `add-hook' at
top level in ebdb-com.el, so loading the file added the hook. That led
to `ebdb-save' being called when batch compiling and testing (ugh). I'll
re-work the docstring.

Thanks,
Eric