From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Tue, 19 Sep 2017 11:13:46 -0700 Message-ID: <87inge8skl.fsf@ericabrahamsen.net> References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505844847 21741 195.159.176.226 (19 Sep 2017 18:14:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 18:14:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 19 20:14:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duN23-0005R9-06 for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 20:14:03 +0200 Original-Received: from localhost ([::1]:44713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duN2A-0006mm-CP for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 14:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duN20-0006lO-Sj for emacs-devel@gnu.org; Tue, 19 Sep 2017 14:14:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duN1x-0004jw-Kk for emacs-devel@gnu.org; Tue, 19 Sep 2017 14:14:00 -0400 Original-Received: from [195.159.176.226] (port=50539 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duN1x-0004gP-C5 for emacs-devel@gnu.org; Tue, 19 Sep 2017 14:13:57 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1duN1n-0004fm-1m for emacs-devel@gnu.org; Tue, 19 Sep 2017 20:13:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:ofRz+goQ0uEiiUAsHZLZxeWRmFM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218528 Archived-At: Kaushal Modi writes: [...] > (or > (buffer-file-name buffer) > (and pred > (progn > (set-buffer buffer) > (and buffer-offer-save (> (buffer-size) 0)))) > (buffer-local-value ;THIS was the newly added condition > 'write-contents-functions buffer)) [...] > @Eric: That makes me wonder.. is it possible to not add this 3rd condition in the or and instead just set buffer-offer-save in the special buffers in your use-case? I've played with this a bit, and am getting hung up on the (and pred... part above. "pred" is nil unless someone's customized `save-some-buffers-default-predicate', so in the majority of cases the check won't even reach `buffer-offer-save'. I don't really know why that (and pred... is in there, and don't feel comfortable just yanking it out. Eric