From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: package.el strings Date: Thu, 26 Apr 2018 07:28:56 -0400 Message-ID: <87in8eqk93.fsf@gmail.com> References: <83y3rpeubc.fsf@gnu.org> <07C02D08-66BB-4454-AA25-B512BFC39A2A@gmail.com> <83vamk965y.fsf@gnu.org> <84FCCBF3-F20F-48E2-B05E-F6DB218D8896@gmail.com> <87lgdarcwi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524742028 14161 195.159.176.226 (26 Apr 2018 11:27:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 26 Apr 2018 11:27:08 +0000 (UTC) Cc: Emacs developers To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 26 13:27:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBf3I-0003YQ-25 for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 13:27:04 +0200 Original-Received: from localhost ([::1]:41631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBf5N-0000lW-9T for ged-emacs-devel@m.gmane.org; Thu, 26 Apr 2018 07:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBf5D-0000kF-LC for emacs-devel@gnu.org; Thu, 26 Apr 2018 07:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBf5A-0003O6-JB for emacs-devel@gnu.org; Thu, 26 Apr 2018 07:29:03 -0400 Original-Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]:35177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBf5A-0003NF-Cl for emacs-devel@gnu.org; Thu, 26 Apr 2018 07:29:00 -0400 Original-Received: by mail-io0-x234.google.com with SMTP id d26-v6so30614093ioc.2 for ; Thu, 26 Apr 2018 04:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=MuZh9fcirrE3ND6Sn6ysgx0Lf8yG2KxbCclRB/+rJVY=; b=Xm0/reY3morYgHuPjgUqLlv/+J3/ubL8U1jQQ0GZtFwo3A+N4XyiDXUT6aEbxv84cE jSFuW2g/1MaP65ct3lZVIXrZzU1PXjsh8Q0iRZT39N1EADo+URO6YgtPTrKYNaV+m0qV 8SGiiZ5OHgGQyg3hBTZv5WbwQPZ+NM05f9lC28iJmX+ztPk0pFM95U8Xz52WBClB9Kvl Nly9oRbKYdJcDcNQtOY+T/ffZZ7FYf7KVKVEwgaaqrUWLa63QM4hvlqsD/WXSCnrSKEH Nl3wUZjMeXy0oXakvG5n5whHQWoybP4YbkamjI3w9CJ3azwNyIJdusMSjRVRZIzyIXJs Nhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=MuZh9fcirrE3ND6Sn6ysgx0Lf8yG2KxbCclRB/+rJVY=; b=V3TY7iztaMSDmD2Oz03o4mtV6W8vTtzO5lSoFMLWXpPcuagNDjI3eo/HIKG03rOcqK gE3gYJYadm+0PMT1PfAWUeIVTeEGoFjUErs2UBzQ5W/+Ml/12jSVxurhMx6hygY9ubZM kz3iSAhSLD9ISi6BlvBpGeM1kfLhlSKBM2FatGN1x8vX23BEGc5TxerTqjaHfb0tmK4y bwC2nN7u3k6GSRdh8UbEY2gixYKjPtMEnvTb4X4t96/Pzgy9KAEEQZ3J9Ipe90qeDKkI lnLHtiyTFk5P5T7iZ2iGp1Tipf0b+f1gHgsJlmVl2bvOgyhlPWHcwBdHukCUxdT83hRK kMHw== X-Gm-Message-State: ALQs6tDlAvVC2zwrljthsd9ZUDoV4pfcrgMWS+o2B38dD1F31gEIF+e8 rUz8LYTFzDwr5TNSzoSmECvT8w== X-Google-Smtp-Source: AB8JxZrpsgMRdRIaPdaLgOFrj/zbm/jHRAONsdB79q/pBqM5fxKK6mh7ZnoLxxQHUasMZBszjPaJNQ== X-Received: by 2002:a6b:a9d1:: with SMTP id f78-v6mr308629ioj.277.1524742139491; Thu, 26 Apr 2018 04:28:59 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p197-v6sm7668450itp.4.2018.04.26.04.28.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 04:28:57 -0700 (PDT) In-Reply-To: (Jean-Christophe Helary's message of "Thu, 26 Apr 2018 15:31:24 +0900") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224903 Archived-At: > I'm not sure I understand the question. This format call produces > messages that are semantically equivalent to the original concat calls > but the concat calls were not localizable so I changed them to something > that we'll eventually be able to properly extract and localize. I meant just the outer (format "%s%s%s%s" ...) vs (concat ...). Is that also needed to make strings localizable? If yes, I think adding a comment would be helpful, because it looks a bit unnatural to me. >>> + (message "Operation finished. Packages that are no longer needed: %d. Type `%s' to remove them" >> This line is getting pretty long, perhaps it should be broken up? > > I guess you mean the line of code? Yes.