From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: map-put! and (setf (map-elt ...) ..) on lists Date: Mon, 17 Dec 2018 12:41:28 +0100 Message-ID: <87imzstm6v.fsf@petton.fr> References: <87y38p4ely.fsf@tromey.com> <8b3d6cc4-43ac-48cc-be4c-917f601faa43@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1545047431 2606 195.159.176.226 (17 Dec 2018 11:50:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2018 11:50:31 +0000 (UTC) Cc: Tom Tromey , emacs-devel@gnu.org To: Stefan Monnier , Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 17 12:50:27 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gYrPn-0000aC-3m for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 12:50:27 +0100 Original-Received: from localhost ([::1]:46217 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYrRt-00046a-68 for ged-emacs-devel@m.gmane.org; Mon, 17 Dec 2018 06:52:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYrHB-0004ck-Of for emacs-devel@gnu.org; Mon, 17 Dec 2018 06:41:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYrHA-00077u-Qm for emacs-devel@gnu.org; Mon, 17 Dec 2018 06:41:33 -0500 Original-Received: from petton.fr ([2a00:5884:8368::1]:34926) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gYrHA-00076o-IK for emacs-devel@gnu.org; Mon, 17 Dec 2018 06:41:32 -0500 In-Reply-To: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1545046891; bh=vV7TfOWsAooCzEiOa4WmFxQQRculjg+ZOoR0eErYkjk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=P9tDMb2Hb5ce1rDJ1IA4YWpQPFCRnZUg0uU/gm4EWNQCOlfcdt94aFhdsdWmry31jFVLvfibZmX2LlLWSRLnBR+MyYbtRDUJX7h5QZW0SaXjzDXgsScYrPalqKejOQp7bg01Fx0NUxK25zrFIZe8JBn+hmQbtDaf7Lg5gvKg2sI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8368::1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231872 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >> So really than complain, please provide constructive alternatives. > > Or just go and rename it directly. Given that seq.el is completely free of side-effects (IIRC, there might be exceptions but I don't think so), and that map.el was done mimicking seq.el but for key/value collections, I like the idea of stating clearly when a function of map.el mutates the argument. Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE1AWqLIYsVPF+7mvg6LzXhmr8+XgFAlwXi2gACgkQ6LzXhmr8 +XjirQgApSQAQWUkeq/5dMFkuwOsvjwZB60Zhf6pn0fVf8BWiWeCfmAee3EKVbLH oMlqfaokdIqZeqo8z3ZfSrjJUkT2FbKSPf/AVpE56iywKcB0n19rXLbQ0hgba3eQ 2UYTUr/GORz66t8tmwwBkriAApWijKD5Ms2kiPgJ22bB6D7pjOso/fF4EkYKu5CI yd/BlUDUPtjOdieZK79SZ38djrNFQxtoD8fUjv+pi9MkuYzn75KcOEKL9pfGyFcG 5fItZdEzyP+07uPZ1NFmvlS88mI5O41UFV8tGaidgIkXBTLure59BdKbX4IZfiWn VE/Z5P6tg0KTTKc7THGmw2dIfj6ZAA== =lMpX -----END PGP SIGNATURE----- --=-=-=--