From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way
Date: Fri, 17 May 2019 14:39:04 +0100 [thread overview]
Message-ID: <87imu9xksn.fsf@tcd.ie> (raw)
In-Reply-To: <jwvzhpdg4mi.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 29 Mar 2019 10:05:43 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el
>>> index b689b51..3f25541 100644
>>> --- a/lisp/gnus/mm-decode.el
>>> +++ b/lisp/gnus/mm-decode.el
>>> @@ -261,13 +262,13 @@ before the external MIME handler is invoked."
>>> ("application/x-.?tar\\(-.*\\)?" mm-archive-dissect-and-inline identity)
>>> ("application/zip" mm-archive-dissect-and-inline identity)
>>> ("audio/wav" mm-inline-audio
>>> - (lambda (handle)
>>> - (and (or (featurep 'nas-sound) (featurep 'native-sound))
>>> + ,(lambda (_handle)
>>> + (and (fboundp 'device-sound-enabled-p)
>>> (device-sound-enabled-p))))
>>> ("audio/au"
>>> mm-inline-audio
>>> - (lambda (handle)
>>> - (and (or (featurep 'nas-sound) (featurep 'native-sound))
>>> + ,(lambda (_handle)
>>> + (and (fboundp 'device-sound-enabled-p)
>>> (device-sound-enabled-p))))
>>> ("application/pgp-signature" ignore identity)
>>> ("application/x-pkcs7-signature" ignore identity)
>>
>> I'm just curious: where do nas-sound/native-sound/device-sound-enabled-p
>> come from?
>
> No idea.
>
>> Are they XEmacs artefacts?
>
> I assume so.
Does that mean they can be removed? Lars?
>> Can/should they eventually be changed to rely on play-sound et al.?
>
> Could be (tho, doesn't play-sound suffer from the problem that
> it's synchronous?)
Yes.
Thanks,
--
Basil
next prev parent reply other threads:[~2019-05-17 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190329124636.25598.41022@vcs0.savannah.gnu.org>
[not found] ` <20190329124636.F3B2320949@vcs0.savannah.gnu.org>
2019-03-29 13:55 ` [Emacs-diffs] master fc2da0d: Gnus: Automatically render text/calendar in a human-friendly way Basil L. Contovounesios
2019-03-29 14:05 ` Stefan Monnier
2019-05-17 13:39 ` Basil L. Contovounesios [this message]
2019-05-17 13:44 ` Lars Ingebrigtsen
2019-05-18 17:13 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imu9xksn.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).