From: Zhu Zihao <all_but_last@163.com>
To: emacs-devel@gnu.org
Subject: [PATCH]: Add xmlns:link namespace for svg-create
Date: Fri, 20 Mar 2020 16:01:49 +0800 [thread overview]
Message-ID: <87imizo3o2.wl-all_but_last@163.com> (raw)
After update my librsvg from 2.46.4 to 2.48.0. Emacs failed to render the svg
image with image embbed generated by svg-create in svg.el.
An example SVG is here: https://pastebin.com/9QnuMy7Y
The reason is svg.el use xmlns:xlink but fails to specify namespace for it. So
new version librsvg reject this SVG.
I've submitted this bug to issue tracker a week before but no reply, so I post
it here again
~~~
From 93188f91906dea87bfbf62e18b608bbd2f84c7af Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Tue, 10 Mar 2020 19:46:03 +0800
Subject: [PATCH] fix: Specify xlink namespace for svg images.
---
lisp/svg.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/svg.el b/lisp/svg.el
index 6a2fc4c90fc..370c9c04e76 100644
--- a/lisp/svg.el
+++ b/lisp/svg.el
@@ -70,7 +70,8 @@ svg-create
(height . ,height)
(version . "1.1")
(xmlns . "http://www.w3.org/2000/svg")
- ,@(svg--arguments nil args))))
+ (xmlns:xlink . "http://www.w3.org/1999/xlink")
+ ,@(svg--arguments nil args))))
(defun svg-gradient (svg id type stops)
"Add a gradient with ID to SVG.
--
2.25.1
next reply other threads:[~2020-03-20 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 8:01 Zhu Zihao [this message]
2020-03-20 8:37 ` Re:[PATCH]: Add xmlns:link namespace for svg-create Zhu Zihao
2020-03-20 9:29 ` [PATCH]: " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imizo3o2.wl-all_but_last@163.com \
--to=all_but_last@163.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).