* Re: master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786
[not found] ` <20210301203556.98CD920E1B@vcs0.savannah.gnu.org>
@ 2021-03-01 21:17 ` Lars Ingebrigtsen
2021-03-01 21:21 ` Lars Ingebrigtsen
2021-03-01 21:27 ` Stefan Monnier
0 siblings, 2 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-01 21:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> branch: master
> commit 0d827c7f52b92aaffe751cf937427938f1ac67de
I'm not sure whether it's this one (there's no "bad" there), but I'm
getting this now:
In completion-pcm--optimize-pattern:
minibuffer.el:3173:26: Warning: Unused lexical variable `rest'
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786
2021-03-01 21:17 ` master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786 Lars Ingebrigtsen
@ 2021-03-01 21:21 ` Lars Ingebrigtsen
2021-03-01 21:27 ` Stefan Monnier
1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-01 21:21 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Lars Ingebrigtsen <larsi@gnus.org> writes:
> In completion-pcm--optimize-pattern:
> minibuffer.el:3173:26: Warning: Unused lexical variable `rest'
But that's correct -- `rest' isn't used in that function?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786
2021-03-01 21:17 ` master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786 Lars Ingebrigtsen
2021-03-01 21:21 ` Lars Ingebrigtsen
@ 2021-03-01 21:27 ` Stefan Monnier
2021-03-01 21:43 ` Lars Ingebrigtsen
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2021-03-01 21:27 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>> branch: master
>> commit 0d827c7f52b92aaffe751cf937427938f1ac67de
>
> I'm not sure whether it's this one (there's no "bad" there), but I'm
> getting this now:
>
> In completion-pcm--optimize-pattern:
> minibuffer.el:3173:26: Warning: Unused lexical variable `rest'
Yes, the change will expose a few new unused var warnings.
Most of them (like this one) should be real and easy to fix in the usual way.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786
2021-03-01 21:27 ` Stefan Monnier
@ 2021-03-01 21:43 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-01 21:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Yes, the change will expose a few new unused var warnings.
> Most of them (like this one) should be real and easy to fix in the usual way.
Yup. Fixed now (on the second attempt after a brain fart on the first
one)...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-01 21:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210301203555.13360.32423@vcs0.savannah.gnu.org>
[not found] ` <20210301203556.98CD920E1B@vcs0.savannah.gnu.org>
2021-03-01 21:17 ` master 0d827c7: * lisp/emacs-lisp/pcase.el: Fix bug#46786 Lars Ingebrigtsen
2021-03-01 21:21 ` Lars Ingebrigtsen
2021-03-01 21:27 ` Stefan Monnier
2021-03-01 21:43 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).