From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Thu, 04 Mar 2021 13:48:12 +0000 Message-ID: <87im67rpwj.fsf@tcd.ie> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> <43A0C407-D217-46AF-8472-28DD2DE80D6C@acm.org> <8735xctggp.fsf@tcd.ie> <87pn0gw95p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 14:50:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHoN0-0008Q1-VY for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 14:50:26 +0100 Original-Received: from localhost ([::1]:33034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHoN0-0005zL-0D for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 08:50:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHoL1-0003z8-1C for emacs-devel@gnu.org; Thu, 04 Mar 2021 08:48:23 -0500 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:44808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHoKu-0005Js-Cf for emacs-devel@gnu.org; Thu, 04 Mar 2021 08:48:22 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id h98so27688910wrh.11 for ; Thu, 04 Mar 2021 05:48:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6DQc4UJz4UqRUR96EXdkYVrBcXgp6m9zvsSrgSjppYM=; b=NVNYronVQ4ionCcgJ0goBUI7/Yn/GLwUoWtGHyoNJRGAdZH39qZPN/xf4AJspa/MlL 9eMhc0mBgGAxwlajnd7WDbDL9EgyzNRvDRh3yWjgbPEvWgPNfGB0gU41MrAop87xI4MP tq8ouycwJELAuiOPIoolIcEjX6sMHV3AvmzPWrtKSKnv27yjccFGvK+xrSNN+WJ2dLPO PVwCywAmnz69ytUh1TfEDTh8Vv70WreHgIhlwY1KkPcNg+r7GMLKKL7O4u6k7NyifeQg R2nKH33BCL6l56aioksdw1+7h9dGulQ8T1uMnqhGuda7k/d4AUhU5kiZ/EqwuesiIh7e Ol5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6DQc4UJz4UqRUR96EXdkYVrBcXgp6m9zvsSrgSjppYM=; b=ngPhbrIf3mA6ee7SlIDbHEbPy5bO7QNd4EqhsI0R5F3BrLUAqfp3yXq/CjYsrvbBky Y4LOkl7sO2Wc3DReP69GVueTHBdevXVRPpRDAlAa5jzIYy7ecugmMbxx0B57M2Wksw0u vVJX6vp1zhDcbhJqoAwG1tKA6Vj5Zf0fUx1CxjkV3ZC+2DosRWAcqBVkprdXt6ee/740 3m9YHZHTRpNG/cKLRLaKeOOzzWhH9WDooYu5rrUq4t5bCfixvt8KekcNUvAL312g7Wnq i388/4ganpWdhxtm9tPmQLVZjeFoIj/CwhXMHERaqff2V18oMD5tv0EsCqikGSheMQIS DL6w== X-Gm-Message-State: AOAM530vRhIbR6rAkyd4r6Q9wOwLlcbJK+h+bhaTu1luguNaleYNiJVc +oB/yAHqN8pfVcrRK3Uq2tj0Vw== X-Google-Smtp-Source: ABdhPJxNOo6ReHr1xS8UqJcj6pSk9RE+l1l6wXCqGbQA+5o5HvC7Y+d9322c9eKHa4Z+HdQcQPBonA== X-Received: by 2002:adf:e7c2:: with SMTP id e2mr4418182wrn.338.1614865694595; Thu, 04 Mar 2021 05:48:14 -0800 (PST) Original-Received: from localhost ([51.37.98.190]) by smtp.gmail.com with ESMTPSA id z1sm7914462wru.95.2021.03.04.05.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 05:48:14 -0800 (PST) In-Reply-To: <87pn0gw95p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 03 Mar 2021 16:26:26 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=contovob@tcd.ie; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265951 Archived-At: Lars Ingebrigtsen writes: > "Basil L. Contovounesios" writes: > >>> Maybe the latter doesn't use the byte-compiled version of the tests. >>> Try something like >>> >>> make TEST_LOAD_EL=no -C test pcase-tests >> >> Indeed, 'make TEST_LOAD_EL=yes test/pcase-tests' succeeds, >> whereas 'make TEST_LOAD_EL=no test/pcase-tests' fails. > > Oh, that explains a lot -- why saying "make foo-tests" often passes while > saying "make check" fails, which has left me scratching my head often. > >> Should 'make test/%' be fixed to behave more like 'make check'? > > Yes, I think so. It seems to be intentional though. Quoth test/Makefile.in: # Whether to run tests from .el files in preference to .elc, we do # this by default since it gives nicer stacktraces. # If you just want a pass/fail, setting this to no is much faster. export TEST_LOAD_EL ?= \ $(if $(findstring $(MAKECMDGOALS), all check check-maybe),no,yes) And test/README: Note that although the test files are always compiled (unless they set no-byte-compile), the source files will be run when expensive or unstable tests are involved, to give nicer backtraces. To run the compiled version of a test use make TEST_LOAD_EL=no ... -- Basil