* Re: master b21f619: * lisp: Remove yet more always-nil variables
[not found] ` <20210311182921.DFCE520B2E@vcs0.savannah.gnu.org>
@ 2021-03-11 18:39 ` Lars Ingebrigtsen
2021-03-11 19:18 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-11 18:39 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> - (setq cperl-hierarchy (list l1 l2 l3))
> + (setq cperl-hierarchy (list () () ())) ;; (list l1 l2 l3)
These comments about the now-removed always-nil variables seem a bit
confusing to me... Is these any point in having these artefacts in the
code, or are you planning to remove them in a subsequent sweep?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: master b21f619: * lisp: Remove yet more always-nil variables
2021-03-11 18:39 ` master b21f619: * lisp: Remove yet more always-nil variables Lars Ingebrigtsen
@ 2021-03-11 19:18 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2021-03-11 19:18 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
> monnier@iro.umontreal.ca (Stefan Monnier) writes:
>> - (setq cperl-hierarchy (list l1 l2 l3))
>> + (setq cperl-hierarchy (list () () ())) ;; (list l1 l2 l3)
> These comments about the now-removed always-nil variables seem a bit
> confusing to me... Is these any point in having these artefacts in the
> code, or are you planning to remove them in a subsequent sweep?
Since this is made as part of the conversion between dynbind and
lexbind, I'm generally worried about the risk that I removed an "unused
lexical var" which really was an "actually used dynamic var".
So, I prefer to keep the old var's code around, in case some problem
shows up that may point to a missing dynbinding of a var named FOO.
If you want to remove those, feel free, of course, but I have no plan to
remove them in the short term (nor to keep track of them so I'll make
sure I'll remove them in the longer term).
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210311182920.3859.19072@vcs0.savannah.gnu.org>
[not found] ` <20210311182921.DFCE520B2E@vcs0.savannah.gnu.org>
2021-03-11 18:39 ` master b21f619: * lisp: Remove yet more always-nil variables Lars Ingebrigtsen
2021-03-11 19:18 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).