From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Tue, 06 Apr 2021 21:49:35 +0300 Organization: LINKOV.NET Message-ID: <87im4z1gbc.fsf@mail.linkov.net> References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32795"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 21:23:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTrIi-0008Po-8O for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 21:23:48 +0200 Original-Received: from localhost ([::1]:40184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTrIh-000112-8O for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 15:23:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrHg-0008Ev-TX for emacs-devel@gnu.org; Tue, 06 Apr 2021 15:22:44 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:38469) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTrHc-0004Cy-04; Tue, 06 Apr 2021 15:22:44 -0400 Original-Received: from mail.gandi.net (m91-129-107-223.cust.tele2.ee [91.129.107.223]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 02009240005; Tue, 6 Apr 2021 19:22:31 +0000 (UTC) In-Reply-To: (Gregory Heytings's message of "Tue, 06 Apr 2021 14:46:09 +0000") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267488 Archived-At: > Okay. Here is the final (?) version of the patch; I forgot to update the > docs in the previous one. I tried it out, and everything works nicely. The only problem I see this code is too hackish: > +(defun icomplete--vertical-reformat-completions () > + "Reformat the completion candidates returned by `icomplete-completions'." > + (save-match-data > + (setq icomplete-current-completions > + (if (string-match "^\\((.*)\\|\\[.*\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" > + icomplete-current-completions) > + (format "%s \n%s" > + (or (match-string 1 icomplete-current-completions) "") > + (match-string 2 icomplete-current-completions)) > + icomplete-current-completions)))) I guess like there are variables that affect formatting of the output e.g. 'icomplete-hide-common-prefix', there could be a new similar variable 'icomplete-add-initial-newline' to add a newline in the 'icomplete-completions' formatting function.