From: Karl Fogel <kfogel@red-bean.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Mon, 03 May 2021 12:21:36 -0500 [thread overview]
Message-ID: <87im3z3f8f.fsf@red-bean.com> (raw)
In-Reply-To: <CADwFkmmyL7-gcArU5kuM6aQMgmxoHB+YvQv0pXM9USCsphta1w@mail.gmail.com> (Stefan Kangas's message of "Mon, 3 May 2021 10:43:29 -0500")
On 03 May 2021, Stefan Kangas wrote:
>Eli Zaretskii <eliz@gnu.org> writes:
>
>>> I don't see how backwards-compatibility is relevant here, but
>>> perhaps
>>> you could provide more specifics.
>>
>> We are now asking for confirmation where previously no question
>> was
>> asked, or am I missing something?
>
>My point is that backwards compatibility is not necessarily the
>most
>important consideration in this case, and that such a stance
>would at
>least need some elaborating.
>
>AFAICT, we routinely make "backward incompatible" changes where
>we see
>a need for it. (But of course we do them with care and
>consideration.)
>
>Luckily, you provided your reasoning below:
>
>> Questions that pop where previously Emacs did something
>> silently can
>> be annoying, which is why I'd prefer to turn this off by
>> default. If
>> someone wants the new behavior, they can enable it.
>
>That's fair enough. To me, the danger of accidentally deleting a
>bookmarks still seems more important. On the one hand, we have
>lived
>with that for a long time, OTOH that is no reason not to try to
>do
>better.
I agree with Stefan's reasoning here.
Backward compatibility is a big deal in an API, but it's a much
smaller deal in an interactive interface behavior. Yes, users
will be prompted in a place where they weren't prompted before,
but the prompt is self-explanatory, and the old behavior was
needlessly dangerous -- it's easy to type "x" accidentally and
lose bookmarks marked for deletion before one had finalized the
list.
If someone had suggested this when I was first implementing the
Bookmark Menu, I think I would have incorporated the suggestion
then and just had this behavior from the beginning. The fact that
it's a change in interactive behavior now is minor compared to the
benefit.
I agree that it should get a NEWS entry, of course, and agree with
Lars' suggestions of `:version' and some documentation tweaks.
Regarding the question of using an undo-based method instead:
Lars Ingebrigtsen wrote:
>In general, I think it's better to offer undo instead of
>prompting.
>That's not always possible, but I think in the bookmark case,
>that
>shouldn't be too difficult -- just register an undo action that
>inserts
>the items that were removed, I think?
I think that's not as good as the confirmation-prompt here, for
two reasons. One, the discoverability issue raised by Stefan
Kangas in his reply; two, Bookmark Menu has a similar basic
look-and-feel to Dired Mode, with which many users are probably
already familiar, and Dired does exactly this kind of confirmation
prompt by default for deleting files. If Bookmark just behaves
the way Dired does by default, that would be consistent with [at
least some] users' expectations.
Best regards,
-Karl
next prev parent reply other threads:[~2021-05-03 17:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 3:43 [PATCH] When deleting in bookmark menu, prompt for confirmation Karl Fogel
2021-05-03 9:16 ` Lars Ingebrigtsen
2021-05-03 12:48 ` Stefan Kangas
2021-05-03 13:02 ` Stefan Monnier
2021-05-04 7:53 ` Lars Ingebrigtsen
2021-05-04 16:29 ` [External] : " Drew Adams
2021-05-03 11:41 ` Eli Zaretskii
2021-05-03 12:47 ` Stefan Kangas
2021-05-03 13:16 ` Eli Zaretskii
2021-05-03 15:43 ` Stefan Kangas
2021-05-03 16:25 ` Eli Zaretskii
2021-05-03 17:21 ` Karl Fogel [this message]
2021-05-03 17:41 ` Eli Zaretskii
2021-05-03 18:28 ` Jim Porter
2021-05-03 18:44 ` Eli Zaretskii
2021-05-03 19:01 ` Jim Porter
2021-05-03 20:52 ` Karl Fogel
2021-05-05 5:24 ` Karl Fogel
2021-05-05 8:11 ` Lars Ingebrigtsen
2021-05-05 19:37 ` Karl Fogel
2021-05-05 20:06 ` Stefan Monnier
2021-05-05 21:38 ` Karl Fogel
2021-05-05 23:17 ` [External] : " Drew Adams
2021-05-05 23:25 ` Karl Fogel
2021-05-06 6:52 ` Matthias Meulien
2021-05-06 15:29 ` Drew Adams
2021-05-08 20:46 ` Matthias Meulien
2021-05-09 8:54 ` Eli Zaretskii
2021-05-09 18:37 ` Karl Fogel
2021-05-09 18:39 ` Eli Zaretskii
2021-05-25 5:38 ` Karl Fogel
2021-05-25 12:09 ` Eli Zaretskii
2021-05-25 20:24 ` Karl Fogel
2021-05-26 11:59 ` Eli Zaretskii
2021-05-26 19:33 ` Karl Fogel
2021-05-07 17:42 ` Karl Fogel
2021-05-07 22:24 ` Drew Adams
2021-05-08 6:13 ` Karl Fogel
2021-05-06 8:49 ` Lars Ingebrigtsen
2021-05-06 13:30 ` Stefan Monnier
2021-05-07 8:40 ` Lars Ingebrigtsen
2021-05-07 12:55 ` Stefan Monnier
2021-05-09 9:55 ` Lars Ingebrigtsen
2021-05-09 15:04 ` Stefan Kangas
2021-05-09 18:01 ` Stefan Monnier
2021-05-10 8:30 ` Lars Ingebrigtsen
2021-05-07 17:40 ` Karl Fogel
2021-05-05 11:56 ` Eli Zaretskii
2021-05-05 21:43 ` Karl Fogel
2021-05-03 17:43 ` [External] : " Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im3z3f8f.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).