From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Cleaning up rcirc Date: Fri, 04 Jun 2021 18:09:33 +0000 Message-ID: <87im2tlcwy.fsf@posteo.net> References: <874kedu0cm.fsf@posteo.net> <877dj94liu.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19651"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 04 20:10:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpEH9-0004uj-EI for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Jun 2021 20:10:31 +0200 Original-Received: from localhost ([::1]:51072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpEH8-0001j9-D2 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Jun 2021 14:10:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpEGO-0000yv-3H for emacs-devel@gnu.org; Fri, 04 Jun 2021 14:09:44 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:54123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpEGJ-0000fQ-Go for emacs-devel@gnu.org; Fri, 04 Jun 2021 14:09:43 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 4E0DB2400E5 for ; Fri, 4 Jun 2021 20:09:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1622830175; bh=Biu0qcqEN9fhHJEctufCIqzQhGwIwyzRo2T7JEn5/VM=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=q9lSsmuD+m+Dg70ZCPN4+olcts7wV/noxlwmy4+LrA3Pt6X1Rk7/a+drbLYYH3NtO mjn55fl7ubWWf11wyf0dW8r7K4YbqwTGEYYJ9l5Y6XmpAuCjQweMUEY1ahnHHKiaRI 4xl3IphQIATcfvWqSum5LeUERrC+JN2S2jfoddiQdfNdImyim+LIiCDvmSFnldK4Fv +FBtFgb7HA1BKuPU5WO3aTfn9i3xQgC6yA/kLQzTd6YRwb8NHa/Ao+LpMRX4eQg5zb XBPjG9miQ8/b0rIHwDN6CR/EIQ5pNJma6rw/8zixZTSGCgKp8WvU8sPUoTEiZHLpBg 5jezuaLRpdBdA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FxW4Z4Hxwz9rxF; Fri, 4 Jun 2021 20:09:34 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <877dj94liu.fsf@igel.home> (Andreas Schwab's message of "Fri, 04 Jun 2021 18:55:37 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270394 Archived-At: Andreas Schwab writes: > On Jun 04 2021, Philip Kaludercic wrote: > >> @@ -846,6 +898,7 @@ rcirc-send-ctcp >> (let ((args (if args (concat " " args) ""))) >> (rcirc-send-privmsg process target >> (format "\C-a%s%s\C-a" request args)))) >> + "Send TARGET a REQUEST via PROCESS." >> >> (defun rcirc-buffer-process (&optional buffer) >> "Return the process associated with channel BUFFER. > > That looks like a pasto. Hmm, I wrote most of the code then tried to selectively separate out each change into it's own commit. Must have added that docstring at the wrong point... Either way, I also noticed there were other issues with the code, that I have since fixed. Would it be ok to push the changes as a feature branch, so that I don't have to re-send all the patches again and again? > Andreas. -- Philip K.