unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org
Subject: Re: Cleaning up rcirc
Date: Fri, 04 Jun 2021 18:09:33 +0000	[thread overview]
Message-ID: <87im2tlcwy.fsf@posteo.net> (raw)
In-Reply-To: <877dj94liu.fsf@igel.home> (Andreas Schwab's message of "Fri, 04 Jun 2021 18:55:37 +0200")

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Jun 04 2021, Philip Kaludercic wrote:
>
>> @@ -846,6 +898,7 @@ rcirc-send-ctcp
>>    (let ((args (if args (concat " " args) "")))
>>      (rcirc-send-privmsg process target
>>                          (format "\C-a%s%s\C-a" request args))))
>> +  "Send TARGET a REQUEST via PROCESS."
>>  
>>  (defun rcirc-buffer-process (&optional buffer)
>>    "Return the process associated with channel BUFFER.
>
> That looks like a pasto.

Hmm, I wrote most of the code then tried to selectively separate out
each change into it's own commit. Must have added that docstring at the
wrong point...

Either way, I also noticed there were other issues with the code, that I
have since fixed. Would it be ok to push the changes as a feature
branch, so that I don't have to re-send all the patches again and again?

> Andreas.

-- 
	Philip K.



  reply	other threads:[~2021-06-04 18:09 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 15:16 Cleaning up rcirc Philip Kaludercic
2021-06-04 16:55 ` Andreas Schwab
2021-06-04 18:09   ` Philip Kaludercic [this message]
2021-06-06 18:41     ` Tassilo Horn
2021-06-06 21:09       ` Philip Kaludercic
2021-06-10 15:50       ` Philip Kaludercic
2021-06-10 19:13         ` Tassilo Horn
2021-06-10 21:54           ` Philip Kaludercic
2021-06-11  5:02             ` Tassilo Horn
2021-06-11  6:35               ` Tassilo Horn
2021-06-11  9:08                 ` Philip Kaludercic
2021-06-11  9:27                   ` Tassilo Horn
2021-06-11  9:44                     ` Philip Kaludercic
2021-06-11 11:10                       ` Tassilo Horn
2021-06-11 14:51                         ` Philip Kaludercic
2021-06-11  8:09               ` Philip Kaludercic
2021-06-07  9:55     ` Lars Ingebrigtsen
2021-07-22 22:14       ` Philip Kaludercic
2021-07-22 22:18         ` Lars Ingebrigtsen
2021-06-06 17:53 ` Bone Baboon
2021-06-07 13:08 ` Zhiwei Chen
2021-06-07 13:20   ` Philip Kaludercic
  -- strict thread matches above, loose matches on Subject: below --
2021-09-11 16:21 Philip Kaludercic
2021-09-11 16:49 ` Tassilo Horn
2021-09-11 17:49   ` Philip Kaludercic
2021-09-11 18:32     ` Tassilo Horn
2021-09-11 20:13       ` Philip Kaludercic
2021-09-11 21:01         ` Tassilo Horn
2021-09-13 22:59           ` chad
2021-09-21 18:52           ` Tassilo Horn
2021-09-21 19:18             ` Philip Kaludercic
2021-09-21 19:47               ` Tassilo Horn
2021-09-25 16:34                 ` Philip Kaludercic
2021-09-26  8:20                   ` Tassilo Horn
2021-09-11 17:56 ` Stefan Monnier
2021-09-11 20:16 ` Philip Kaludercic
2021-09-13  8:50 ` Lars Ingebrigtsen
2021-09-13  9:53   ` Stefan Kangas
2021-09-13 10:20     ` Tassilo Horn
2021-09-13 15:00       ` Amin Bandali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im2tlcwy.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).