From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Cleaning up rcirc Date: Fri, 11 Jun 2021 09:44:40 +0000 Message-ID: <87im2kwx9z.fsf@posteo.net> References: <874kedu0cm.fsf@posteo.net> <877dj94liu.fsf@igel.home> <87im2tlcwy.fsf@posteo.net> <87sg1urfwu.fsf@gnu.org> <87sg1pwwfd.fsf@posteo.net> <87zgvx34s4.fsf@gnu.org> <87sg1pidwy.fsf@posteo.net> <87a6nx9ecz.fsf@gnu.org> <877dj0aoop.fsf@gnu.org> <87k0n0ixag.fsf@posteo.net> <874ke4agi9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 11 11:45:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrdjW-000AMS-Cs for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 11:45:46 +0200 Original-Received: from localhost ([::1]:45268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrdjV-0002NS-EE for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Jun 2021 05:45:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrdiX-00013w-Gf for emacs-devel@gnu.org; Fri, 11 Jun 2021 05:44:45 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:55775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrdiV-00085O-Ms for emacs-devel@gnu.org; Fri, 11 Jun 2021 05:44:45 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 7CD3E2400FC for ; Fri, 11 Jun 2021 11:44:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1623404681; bh=x1EnE/PUe/t+aBz5XeVgETzRWLfQXymwqZdD0UZ/R6I=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Io4TH3QrmCwPoRYsUXD37Tzi+TK3kWIDA+67xSV8ouudIE6ei6EZ3VdOZaRrOMnvy hRTfBtTU7ckaPNnSF4JuC8zgBc3iHuCB8wqD3qruIQ9WwCVF1VC9KKFImrRCtiT9G5 a7ywz+C3gqnHCe3B/KfoV3zsTBb+nYtYIv2Q27N0yG8sbhgjIYq+uu478Emj46mzJe uh/PPJieSrQa0nn6zSEk88JkECYoILnQ76Tlu5L1XcpiBUPdkr6J3PDefICi/qs53C pvEhYQnBYKkShRjgPexZdLx3eYlR2SkoO0+yo3oMvpbYDXd4lWNXNfQVpq74k+UVp1 rHqiD1LiegdOA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G1bXm4r5nz9rxR; Fri, 11 Jun 2021 11:44:40 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <874ke4agi9.fsf@gnu.org> (Tassilo Horn's message of "Fri, 11 Jun 2021 11:27:40 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270692 Archived-At: Tassilo Horn writes: > Hi Philip, > >>> Here's one thing I noticed just now but which is probably not caused by >>> your changes, but who knows: I use `rcirc-track-minor-mode' which >>> displays abbreviated channels with activity in the mode-line like >>> [#emacs,#git] and makes it possible to switch/cycle through them with >>> `rcirc-next-active-buffer'. >>> >>> With the indicator above and a 2-side-by-side window configuration >>> (terminal frame, if that matters) I call the latter function twice. In >>> the current mode-line, the indicator becomes [] (no unseen activity), >>> however, in the other window it is still [#emacs,#git] and becomes [] >>> not before switching to that other window. >> >> Hmm, I did not change anything about rcirc-track-minor-mode, but I do >> remember trying out adding (rcirc-update-activity-string) to the end >> of rcirc-next-active-buffer. Does that change anything in your case? > > No, not really. `rcirc-update-activity-string' just updates > `rcirc-activity-string'. Maybe that should call > > (force-mode-line-update t) > > at least if the new and old activity string aren't equal? I cannot reproduce the issue (at least in my GUI instance, I'll take a look at TUI). Can you observe it making a difference? > Bye, > Tassilo > > > -- Philip K.