From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: GNU Emacs: A configurable browser Date: Sat, 15 Jan 2022 15:31:05 +0800 Message-ID: <87ilulcv5y.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16281"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Emacs Devel , Akira Kyle To: Anand Tamariya Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 15 08:37:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8dce-00043r-Pr for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 08:37:12 +0100 Original-Received: from localhost ([::1]:43880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8dcd-0007PC-EQ for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jan 2022 02:37:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8dWx-0004l7-Hx for emacs-devel@gnu.org; Sat, 15 Jan 2022 02:31:21 -0500 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:38984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8dWt-0001Al-Qf for emacs-devel@gnu.org; Sat, 15 Jan 2022 02:31:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1642231874; bh=nvvFU+p3YPKpWC5gmWjH7DTOvQieNYZxLaaMZQW478M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=IRPlOqXY12WgfohDTyO2rn3v7RHxr5Sa3dQPfne4SCVgrPCSl860X/2y3wU+2T9r0iB+rap548n65b5rZO/4dsw7KPn9h38dZei7MMzatADBWUQqCCmGDe669HKRUfnYCTqoXA2j/tIoC7KBTBK/YaW5Ub2StHkE3pXIRFwLqnqKXz8dWsw+nZCUofVzy9Ds9mfj1K0eufPcXuiQIqOPokmOCLUqwLcOd5LhWoWVmEMV0dmmvuWxdMzWoskXxPYPt2iPrX+PAG51PKs6QDXGG27gkGTzfmKCwofdbIUt/VbVmM0uJOw6xWFTzvolTGm1RKzuSTRrv7Z0r5TYoGELpw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1642231874; bh=3JtwEY9Zlm78GgPSR0iXSm3ofj6X9EW+WBAIZiSplLC=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=M40iUEM1dIrDpjErBmDf27KiPNmOrmhDBKzrpT424/mzojKUHiwK0tzN42stRPntXM+In7cZg1CJ+CwwRlIgZIn/j2oTvR3VP5rpwLRVOLHPoKRjL1W8G02dqjPrJacJceWHhRKqD9C78tic9lMbcw1S/g+Et9OI4FJAbiF3B/PPi6cmnfVLZueCnEzwHLLU/QaAkLyRXDtStGVgPuqSRNPHZQJgIDls5qDmhvPPZngUMNBYASf8O5xI0Nwm4PIxs5+hsC/BtYKuYmy+u5/CA/zrV85Uy/yxnBQ52NAq953Quujwuu3i1zcOxZLgKBBU9rhM9z1RSR+oCJoIlXrxtg== X-YMail-OSG: axfAet0VM1mU33j3.wMRYd9uuk2C_h6bYgdJfECs2eMev2XUJK8IACCuzD7qXTY owniN63IE4E_31QS_B9Iav5NJqKZwuF1gKhF2Rss08u6_4uWpV8Iva_m_nNB4_L2zzzSpQjhv0XF ._H0HBPGuAAEmu3PqTY5ZRVhv.uIOACGGZAd53Cjf1YByCN_ei4IWDhGxl0PddcaohZtKMfuXoaV wB0GuFJGvHoWB_FluI9fudOMQ1wCo.EFcB5PLdUaVeb6Kgb.E1OZjB62pnwlqxy3YKKYTph3M3lr f90Q6DMb2ODt1OWrWSVcjsSwK2J3nDh4iY88TNswmqpK49GbyQP9tJcoIysdagIQPWbY7DzOv7FH pWW3jOEOBIzU5YcMHuLl72379EkXmtu6GS5wOQwtYNuWVZJKkMgvpt1m1Rylv2tCnxE10roFAYw. HbykyCECFu8Xoh3A4Rc2PxzgrZ59UOZFbYJ1G1FBNk5J27pHGcL.pxlYyY8p0sLvqmlhed0sPfV8 facvbadO6gnw6TaoC8XoDBrchEsQp7riLySMNlnLEk3WjXdZf_gIcmRi1TFdghXcgVctFfajReKp edaS3aTKZggapyCoiPlXsDkfg3O.AjfbrAyqZGL6Y5mvKXIjozF5Wu_z5kfOipEG2wvipGCZ5AS3 jGX7hqeEOmibmOcaclFPA_e58CanKdBa2HnUFDZjs0GQn_aNPEZ3OhZf5LJ7SgKkYiufuyGIMoEG DmZ6ssitL2WdudTALm0Q0VL2L.SDS3TPfb5r6UOY7QUIoNZicvtwze.KIE4FOjFYi2IU.OmhjYkk 2wmbCuI6yftPGEZ5CBhyx4_fQ4q7BxJFZ5AS6N6lbA X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 15 Jan 2022 07:31:14 +0000 Original-Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 0907eb31788d2a576fa339bfe3be4323; Sat, 15 Jan 2022 07:31:09 +0000 (UTC) In-Reply-To: (Anand Tamariya's message of "Sat, 15 Jan 2022 12:37:05 +0530") X-Mailer: WebService/1.1.19594 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.206; envelope-from=luangruo@yahoo.com; helo=sonic312-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284766 Archived-At: Anand Tamariya writes: > https://lifeofpenguin.blogspot.com/2022/01/gnu-emacs-configurable-browser.html I don't understand why you chose to describe the code in master as a "competing implementation", if you want to work with us to have your changes installed, which is what you proceed to say in your article. I hope that you will improve your choice of words in the future, because what you have said will result in many people misunderstanding the nature of the code in master. > https://gitlab.com/atamariya/emacs/-/blob/dev/src/xwidget.c It would be much easier for me to review your changes if you based them off a recent (in contrast with 10 months old) copy of master, and submitted them in the form of a patch. Most of the features which you posted are already available in xwidget-webkit or other areas of Emacs, so I'm confused as to exactly what changes you have made. Judging by the code in your repository, you also have remanants of many irrelevant features, such as support for xembed. Could you please explain exactly which changes you have made, remove irrelevant features from your changes, rebase them onto master, and then send them as a patch? Thanks in advance. > https://gitlab.com/atamariya/emacs/-/blob/dev/lisp/webkit/webkit-ace.el This file is written by Akira Kyle, not by you, who has been active around here lately. Akira, have you signed the papers necessary for it to be included in Emacs? > https://gitlab.com/atamariya/emacs/-/blob/dev/etc/webkit/hints.js > https://gitlab.com/atamariya/emacs/-/blob/dev/etc/webkit/hints.css To the best of my knowledge, these two files are also written by Akira.