Re: master 452f46d366 2/2: Allow fractional values of `polling-period'

Re: master 452f46d366 2/2: Allow fractional values of `polling-period'

[Basil L. Contovounesios]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Po Lu [2022-01-20 20:19 -0500] wrote:

> branch: master
> commit 452f46d3665e1bfab93ec14003484ce57b636471
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
>     Allow fractional values of `polling-period'

I believe this gave rise to the following build error here:

keyboard.c: In function ‘syms_of_keyboard’:
keyboard.c:12085:3: error: ‘poll_timer_time’ undeclared (first use in this function)
12085 |   poll_timer_time = Qnil;
      |   ^~~~~~~~~~~~~~~

Is this the right band-aid?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-initialization-of-poll_timer_time.patch --]
[-- Type: text/x-diff, Size: 887 bytes --]

From 1ca6928c843fcbbaa35a7a947f905ca287c5c2fb Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Fri, 21 Jan 2022 15:26:57 +0200
Subject: [PATCH] Fix initialization of poll_timer_time

* src/keyboard.c (syms_of_keyboard): Variable poll_timer_time is
declared only under POLL_FOR_INPUT, so guard its initialization
accordingly.
---
 src/keyboard.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/keyboard.c b/src/keyboard.c
index 6f1614a7df..a18664f78a 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -12082,8 +12082,10 @@ syms_of_keyboard (void)
   help_form_saved_window_configs = Qnil;
   staticpro (&help_form_saved_window_configs);
 
+#ifdef POLL_FOR_INPUT
   poll_timer_time = Qnil;
   staticpro (&poll_timer_time);
+#endif /* POLL_FOR_INPUT */
 
   defsubr (&Scurrent_idle_time);
   defsubr (&Sevent_symbol_parse_modifiers);
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 20 bytes --]


Thanks,

-- 
Basil

Re: master 452f46d366 2/2: Allow fractional values of `polling-period'

[Po Lu]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Po Lu [2022-01-20 20:19 -0500] wrote:
>
>> branch: master
>> commit 452f46d3665e1bfab93ec14003484ce57b636471
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     Allow fractional values of `polling-period'
>
> I believe this gave rise to the following build error here:
>
> keyboard.c: In function ‘syms_of_keyboard’:
> keyboard.c:12085:3: error: ‘poll_timer_time’ undeclared (first use in this function)
> 12085 |   poll_timer_time = Qnil;
>       |   ^~~~~~~~~~~~~~~
>
> Is this the right band-aid?

It is, thanks.  I installed a fix to that effect.