From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.devel Subject: Re: sorting in C Date: Sun, 27 Feb 2022 18:42:11 +0800 Organization: Hong Kong University of Science and Technology Message-ID: <87ilt0fv5o.fsf@ust.hk> References: <87ilt7bokp.fsf@ust.hk> <83tucrt75y.fsf@gnu.org> <8735kakymb.fsf@ust.hk> <835yp5u5h7.fsf@gnu.org> <87ee3thhh3.fsf@ust.hk> <83zgmhsp13.fsf@gnu.org> <8735k97k4b.fsf@ust.hk> <83wnhlsm3m.fsf@gnu.org> <87pmn9gp5q.fsf@ust.hk> <87h78l9h7x.fsf@ust.hk> <83zgmcojj5.fsf@gnu.org> <87o82sfzc6.fsf@ust.hk> <83r17oodxi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:FqCAXYjsE7yn645JJKNatE+GNQI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 27 11:43:00 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOH12-0003VR-5b for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Feb 2022 11:43:00 +0100 Original-Received: from localhost ([::1]:55974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOH10-0004Cf-Ol for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Feb 2022 05:42:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOH0R-0003Wi-Cs for emacs-devel@gnu.org; Sun, 27 Feb 2022 05:42:23 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:56332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOH0P-00079b-1i for emacs-devel@gnu.org; Sun, 27 Feb 2022 05:42:23 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nOH0M-0002eo-La for emacs-devel@gnu.org; Sun, 27 Feb 2022 11:42:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286715 Archived-At: >>>>> "EZ" == Eli Zaretskii writes: [...] >> When I need new memory I call >> >> : specpdl_ref sa_count = SPECPDL_INDEX (); : a = (Lisp_Object *) >> record_xmalloc (need * sizeof (Lisp_Object)); >> >> and I save =sa_count=; I guess =record_xmalloc= handles freeing >> the memory on exception. Later during the sorting process I free >> the memory explicitly with >> >> : safe_free (sa_count) >> >> Does this seem right? (Probably, since I've been running this way >> for awhile and would have expected lots of problems if I weren't >> allocating and freeing the memory :)) EZ> I'd rather you didn't use safe_free, since that is for EZ> SAFE_ALLOCA etc. Just use unbind_to directly, like we do EZ> elsewhere where record_xmalloc is used. Ahh, didn't know about that function. I replaced the safe_free with unbind_to and seems to work fine. Thanks, Andy -- Andrew Cohen