From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Sun, 27 Mar 2022 13:26:56 -0700 Message-ID: <87ilrzuoof.fsf@ericabrahamsen.net> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9261"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jai Flack Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 27 22:27:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYZUR-0002BT-U0 for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 22:27:55 +0200 Original-Received: from localhost ([::1]:41762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYZUQ-000469-GR for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 16:27:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYZTg-0003Pi-Gm for emacs-devel@gnu.org; Sun, 27 Mar 2022 16:27:08 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:58306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYZTf-0003GI-0N for emacs-devel@gnu.org; Sun, 27 Mar 2022 16:27:08 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5C5B3FA7EA; Sun, 27 Mar 2022 20:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1648412818; bh=6CB8U9mScwVTNzt+e3HrzRGQuoQ13nQJU8HDkNDLYXw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=sbySSq4HiZO8cSP1lz1tffKbV7irb4S8opoUbkPkjJm1sEJaahsh1u6dzXN/ShDsq 8c3rdpvxttSJea1FKpTirtRL5qa/oRDkfBX7m6ozayZPliGlXa0Q5Yy8NZRJnlEdCD 41NdiAILxaYdEH4b2NR0KDiKueb19NCYqbGycirY= In-Reply-To: <87ils0yqxd.fsf@disroot.org> (Jai Flack's message of "Sun, 27 Mar 2022 14:12:30 +1000") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287511 Archived-At: Jai Flack writes: > Eric Abrahamsen writes: > >> Jai Flack writes: >> >>> Eric Abrahamsen writes: >>>> Hi! Thanks very much for working on this. Wouldn't it make more sense to >>>> include this in Emacs proper? Gnus-search is new enough that it doesn't >>>> seem useful to let users of prior Emacs versions to install >>>> gnus-search-mu from the repos... What do you think? >>> >>> I'm happy for it to be included in Emacs proper; though possibly as both >>> a la modus-themes as it's missed the release window for Emacs 28 (if I >>> understand the release cycle correctly). >>> >>> Shall I convert this to a patch for gnus-search.el? >> >> Sure! Thanks. >> >> Please note that engine custom options like -remove-prefix and >> -config-directory have been moved away from `getenv' to something like: >> >> (expand-file-name "foo" "~") >> >> and it would be nice to stick to that convention. > > Sure. > >> Otherwise, please make sure that the first line of docstrings are a >> complete sentence, and there's no need for a blank line between the >> first sentence and whatever comes after. > > Right. > >> Out of curiosity, what is `ansi-color-filter-apply' doing there? > > I think I had trouble with mu giving ANSI escape codes to Emacs, it > might no longer be a problem or maybe there is a better solution. Okay, sounds good! ansi-color is built in so there's no harm in that. I'm assuming you have done copyright assignment. Do you have push permissions for ELPA and/or Emacs proper?