Re: [ELPA] New package: gnus-search-mu

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Jai Flack <jflack@disroot.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Jai Flack <jflack@disroot.org> writes:
>>
>>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>>> Hi! Thanks very much for working on this. Wouldn't it make more sense to
>>>> include this in Emacs proper? Gnus-search is new enough that it doesn't
>>>> seem useful to let users of prior Emacs versions to install
>>>> gnus-search-mu from the repos... What do you think?
>>>
>>> I'm happy for it to be included in Emacs proper; though possibly as both
>>> a la modus-themes as it's missed the release window for Emacs 28 (if I
>>> understand the release cycle correctly).
>>>
>>> Shall I convert this to a patch for gnus-search.el?
>>
>> Sure! Thanks.
>>
>> Please note that engine custom options like -remove-prefix and
>> -config-directory have been moved away from `getenv' to something like:
>>
>> (expand-file-name "foo" "~")
>>
>> and it would be nice to stick to that convention.
>
> Sure.
>
>> Otherwise, please make sure that the first line of docstrings are a
>> complete sentence, and there's no need for a blank line between the
>> first sentence and whatever comes after.
>
> Right.
>
>> Out of curiosity, what is `ansi-color-filter-apply' doing there?
>
> I think I had trouble with mu giving ANSI escape codes to Emacs, it
> might no longer be a problem or maybe there is a better solution.

Okay, sounds good! ansi-color is built in so there's no harm in that.

I'm assuming you have done copyright assignment. Do you have push
permissions for ELPA and/or Emacs proper?