From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master ed84f24a21: Make `signal-process' allow completing over signal names Date: Mon, 27 Jun 2022 09:20:26 +0800 Message-ID: <87ilomewbp.fsf@yahoo.com> References: <165627647702.21409.11158107897633930882@vcs2.savannah.gnu.org> <20220626204757.57AB1C01685@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 27 03:21:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5dRb-0009Au-Oe for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jun 2022 03:21:39 +0200 Original-Received: from localhost ([::1]:49330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5dRa-0006qn-Gu for ged-emacs-devel@m.gmane-mx.org; Sun, 26 Jun 2022 21:21:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5dQh-00065L-Pn for emacs-devel@gnu.org; Sun, 26 Jun 2022 21:20:43 -0400 Original-Received: from sonic302-20.consmr.mail.ne1.yahoo.com ([66.163.186.146]:46026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5dQf-0003fj-SW for emacs-devel@gnu.org; Sun, 26 Jun 2022 21:20:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1656292837; bh=HebtCc0HJpB/uQTmJ4rzyY1nYyweqWC3l0WFEKbg7BU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=MHq0EehVsUqk05HIQwoxK+x5oyX+/AbJsnK6jQAVaFx+RcZf2M+2pd/ys1mGHjkygj6cvGU41zVeE63Ffd/MsQrQJGy+f84WO/FJWRgAV8QOq+WJ7KkA6Y5O3t3tZqwFOW1IlQsOlDeowZxoZ2UBpykOWNLOJREVMDpjktA8B3/Zil1VCBoRljv7xhMdnxOwIm/q/aDvsSrIIN04YfBlZJ6y0JCq0veHq4X2Qu+LH8nyQIgl0zaAwZPQT261CPSNHADgKQJgGyw+RIgPKQ3cHJKzHEc0Owgd1TTnqUZEhT0oTRbpcYeV8fZJGn7Lzikqcgnh2xLLyB6ayjgqcuKs9w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1656292837; bh=Igl33vyKHF3lJ8WmGku3XUgU654IxNXjMP+VQU+5Qgk=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TMqxXhyBWPUoVdbxkIvovcO2dDglBUwFC90UqHjf2zVNo9fw7VdkMe688OGu40Yp2nndxE3kDtJIUoEnDCv9yq6Or41/yFEGCXDeUgdmw8CWWm7AEdZF0azYHS7hJHrkjKzfHAYyhOYpbvyLKwzni+v6loGIQIBi5512XLgkc7KkNZYe7OriFHO4NVFY7v3TmhOjztUXcKZpwirBOBposOEoTfUQQsLr4BCf9jxwPH2nfJKiBnBFQ190z5saF1aliHEuVXrEfrjRpZ9HfnULBmlnIqZvx490BOSTAXf8cHnKb6eE+cUo9Fl0XSD7NSMYddZqvNHkVgJ2Yoy4xDx0WA== X-YMail-OSG: kMmbl30VM1lX5AZnOBiFW2GKEifBsVq6tv8gwIOdYAkJN0K84SDOaTNTH53QsRX TjEss3bGwASf8JMyABWHHllY83PiRjqs5Xn1Zxll07OojgCNVcikI12mOtktrFjyFMR02NxQbKs0 UcgsTahyglV26TTPXn1I1hEMyUpWqCNo7YH0DfBqR_Xl_GOGKiJ4PwloamVe.DjgtCf.BTbqA9Re VJy4l_Dbz5IJv1PwOY30NNxK8c8hfkF8NhaSrQ29o7Hc1k.nePmCBgZiiNxIZ4Y4EF7e3M6B5qTR F.PNLeMSBMWsXgRgb8mktEgpe32ml4QZsaxmsc9eo.fJXU2U0odtDBF0LJZDwT27mLruxYamFdQi q8UpMOSXuFnAuPLQuqeRKC6_tE5QaY3mII2M3YUbcqbbHQgcBqYn9rgrPbmMJm5ucCPrPqiJzzmA Jqi3TGUV0NRr2FGn9T0YAMOGLB3aFxJ5nNxrF7oE0e0j.bcH2rejHYw5HAKSmZiXsMOl0p_ZDa4X x06CVTZ4bhJcDmOLNmY30Arl56w.CuXguUB01K0Gg7oGpNLdsf09HGa62dLyRgF6nq148O.X2Y2z t1BBqjgBVBrKA_dsh226_wcrcRLQC7qmZjrWvaRtOLtiFqEx391eogoixeFfatsPBHalIZyybnpj KkayuF15wFKhP2OK0v.yMJ65FSGPUul28E2siVx6n_7TulgLR7WbAOLDop8Hix1M4eAJLiQOdcqK mNDQtgz9dAIw6Y5YKm3XrST6a85T5QgaJk04oOqi4MDasdZ_kDj_oh0te5_F9wH03Onx4PpahBGi GxRkKpJS.qIJSmTg.XW_XnJRqpuA3Kh9xG4O1KEp3u X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Mon, 27 Jun 2022 01:20:37 +0000 Original-Received: by hermes--canary-production-sg3-559fcd5995-chz8s (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fb5a995b02ece52101a44235d8522710; Mon, 27 Jun 2022 01:20:31 +0000 (UTC) In-Reply-To: <20220626204757.57AB1C01685@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sun, 26 Jun 2022 16:47:57 -0400 (EDT)") X-Mailer: WebService/1.1.20280 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.146; envelope-from=luangruo@yahoo.com; helo=sonic302-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291639 Archived-At: Lars Ingebrigtsen writes: > +DEFUN ("signal-names", Fsignal_names, Ssignal_names, 0, 0, 0, > + doc: /* Return a list of known signal names on this system. */) > + (void) > +{ > + char name[SIG2STR_MAX]; > + Lisp_Object names = Qnil; > + for (int i = 0; i < 255; ++i) > + { > + if (!sig2str (i, name)) > + { > + names = Fcons (build_string (name), names); > + } > + } > + return names; > +} > + Shouldn't the "255" be NSIG instead? And what about systems where POSIX signal handling doesn't really apply, such as MS Windows and MS-DOS? Thanks.