From: Sean Whitton <spwhitton@spwhitton.name>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments
Date: Thu, 22 Sep 2022 09:06:48 -0700 [thread overview]
Message-ID: <87illfo0kn.fsf@melete.silentflame.com> (raw)
In-Reply-To: <87v8pfbw1g.fsf@gmail.com> (Robert Pluim's message of "Thu, 22 Sep 2022 11:25:31 +0200")
Hello,
On Thu 22 Sep 2022 at 11:25AM +02, Robert Pluim wrote:
>>>>>> On Wed, 21 Sep 2022 15:33:02 -0400 (EDT), Sean Whitton <spwhitton@spwhitton.name> said:
>
>
> Sean> +(defvar vc-want-edit-command-p nil
> Sean> + "If non-nil, let user edit the VC shell command before running it.")
> Sean> +
> Sean> ;; Common command execution logic
>
> Is the intent that someone would setq this to t? If so it should be a
> defcustom. If thatʼs not the intent, but itʼs just being used to track
> the prefix args to the various changed commands, then I think it
> shouldnʼt appear in the docstring.
It's the latter, it's not meant to be setq.
What exactly do you think shouldn't appear in the docstring?
--
Sean Whitton
next prev parent reply other threads:[~2022-09-22 16:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166378878197.3568.7077863090259744101@vcs2.savannah.gnu.org>
[not found] ` <20220921193303.1B687C11D81@vcs2.savannah.gnu.org>
2022-09-22 9:25 ` master 101f3cf5b9: Add support for user edits to VC command arguments Robert Pluim
2022-09-22 13:24 ` Stefan Monnier
2022-09-22 16:08 ` Sean Whitton
2022-09-22 16:55 ` Stefan Monnier
2022-09-22 21:18 ` Sean Whitton
2022-09-23 6:39 ` Juri Linkov
2022-09-22 22:21 ` [External] : " Drew Adams
2022-09-22 16:06 ` Sean Whitton [this message]
2022-09-23 8:03 ` Robert Pluim
2022-09-23 16:15 ` Sean Whitton
2022-09-22 18:45 ` Stefan Monnier
2022-09-22 21:38 ` Sean Whitton
2022-09-22 22:41 ` Stefan Monnier
2022-09-23 17:56 ` Sean Whitton
2022-09-23 19:32 ` Stefan Monnier
2022-09-23 21:51 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87illfo0kn.fsf@melete.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).